WA-VERIFY-075: Verify Sidekiq worker error handling patterns under Rails 7.1 appraisal

[kitcommerce]

Summary

Following WA-SEC-019 (narrowing broad rescue clauses), verify that Sidekiq workers handle errors correctly under the Rails 7.1 appraisal — specifically that StandardError rescues don't suppress legitimate retry-triggering errors.

Approach

# Find all Sidekiq workers
grep -r 'include Sidekiq::Worker' --include='*.rb' -l .

# Check for rescue patterns in workers
grep -rn 'rescue\b' --include='*.rb' core/app/workers/ | grep -v '^\s*#'

# Run worker tests under Rails 7.1 appraisal
BUNDLE_GEMFILE=gemfiles/rails_7_1.gemfile bundle exec rake core_test TEST_FILES="test/workers/**"

Acceptance Criteria

• All Sidekiq workers identified
• Rescue patterns reviewed (no bare rescue remaining, StandardError boundaries appropriate)
• Worker tests pass under Rails 7.1 appraisal
• Document any workers with non-retryable error handling that should be flagged

Client Impact

None (verification only). Any fixes would be separate issues.

Notes

Related to WA-SEC-019 (PR #1040 — narrow broad rescue clauses).

[kitcommerce]

PR opened for WA-VERIFY-075: #1056

Key findings:

• All 50 Sidekiq workers identified and rescue patterns reviewed
• IndexCategoryChanges (line 38) has a bare rescue that catches Exception — high severity, suppresses SIGTERM/graceful shutdown; recommend changing to rescue StandardError
• Rails 7.1 appraisal cannot run (mongoid < 8 blocks activemodel 7.1); Rails 7.0 appraisal has pre-existing boot failure
• Full findings in notes/sidekiq-worker-error-handling-2026-03-17.md