Skip to content

Commit df3ad26

Browse files
authored
Merge pull request SeequentEvo#139 from wordsworthc/fix/health-check-parameters
Fix/health check parameters
2 parents ffdda73 + 3af5069 commit df3ad26

6 files changed

Lines changed: 1881 additions & 1871 deletions

File tree

UV_VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.7.20
1+
0.9.7

packages/evo-sdk-common/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[project]
22
name = "evo-sdk-common"
33
description = "Python package that establishes a common framework for use by client libraries that interact with Seequent Evo APIs"
4-
version = "0.5.8"
4+
version = "0.5.9"
55
requires-python = ">=3.10"
66
license-files = ["LICENSE.md"]
77
dynamic = ["readme"]

packages/evo-sdk-common/src/evo/common/utils/health_check.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ async def _check_service_health(
3535
"""
3636
query_params = {}
3737
if full is True:
38-
query_params["full"] = True
38+
query_params["full"] = "true"
3939
if check_type in {HealthCheckType.FULL, HealthCheckType.STRICT}:
40-
query_params["check_dependencies"] = True
40+
query_params["check_dependencies"] = "true"
4141
if check_type is HealthCheckType.STRICT:
42-
query_params["strict"] = True
42+
query_params["strict"] = "true"
4343

4444
return await connector.call_api(
4545
RequestMethod.GET,

packages/evo-sdk-common/tests/common/utils/test_health_check.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ async def test_get_service_status_with_dependencies(self, _label: str, content:
5959
with self.transport.set_http_response(status_code, content):
6060
status = await get_service_status(self.connector, "test", check_type=HealthCheckType.FULL)
6161

62-
self.assert_request_made(RequestMethod.GET, "/test/health_check?check_dependencies=True")
62+
self.assert_request_made(RequestMethod.GET, "/test/health_check?check_dependencies=true")
6363
self.assertEqual(ServiceStatus(content), status)
6464

6565
@using_test_data(full=False, with_dependencies=True, strict=True)
@@ -69,7 +69,7 @@ async def test_get_service_status_with_dependencies_strict(
6969
with self.transport.set_http_response(status_code, content):
7070
status = await get_service_status(self.connector, "test", check_type=HealthCheckType.STRICT)
7171

72-
self.assert_request_made(RequestMethod.GET, "/test/health_check?check_dependencies=True&strict=True")
72+
self.assert_request_made(RequestMethod.GET, "/test/health_check?check_dependencies=true&strict=true")
7373
self.assertEqual(ServiceStatus(content), status)
7474

7575
def _check_health_check_response(self, content: dict, status_code: int, response: ServiceHealth) -> None:
@@ -95,15 +95,15 @@ async def test_get_service_health(self, _label: str, content: dict, status_code:
9595
with self.transport.set_http_response(status_code, json.dumps(content)):
9696
response = await get_service_health(self.connector, "test", check_type=HealthCheckType.BASIC)
9797

98-
self.assert_request_made(RequestMethod.GET, "/test/health_check?full=True")
98+
self.assert_request_made(RequestMethod.GET, "/test/health_check?full=true")
9999
self._check_health_check_response(content, status_code, response)
100100

101101
@using_test_data(full=True, with_dependencies=True, strict=False)
102102
async def test_get_service_health_with_dependencies(self, _label: str, content: dict, status_code: int) -> None:
103103
with self.transport.set_http_response(status_code, json.dumps(content)):
104104
response = await get_service_health(self.connector, "test", check_type=HealthCheckType.FULL)
105105

106-
self.assert_request_made(RequestMethod.GET, "/test/health_check?full=True&check_dependencies=True")
106+
self.assert_request_made(RequestMethod.GET, "/test/health_check?full=true&check_dependencies=true")
107107
self._check_health_check_response(content, status_code, response)
108108

109109
@using_test_data(full=True, with_dependencies=True, strict=True)
@@ -113,5 +113,5 @@ async def test_get_service_health_with_dependencies_strict(
113113
with self.transport.set_http_response(status_code, json.dumps(content)):
114114
response = await get_service_health(self.connector, "test", check_type=HealthCheckType.STRICT)
115115

116-
self.assert_request_made(RequestMethod.GET, "/test/health_check?full=True&check_dependencies=True&strict=True")
116+
self.assert_request_made(RequestMethod.GET, "/test/health_check?full=true&check_dependencies=true&strict=true")
117117
self._check_health_check_response(content, status_code, response)

pyproject.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ extend-select = ["I", "RUF022"]
4444
[tool.ruff.lint.isort]
4545
known-first-party = ["evo"]
4646

47+
[tool.uv]
48+
required-version = ">=0.9.0,<0.10.0"
49+
4750
[tool.uv.sources]
4851
evo-sdk-common = { workspace = true }
4952
evo-colormaps = { workspace = true }

0 commit comments

Comments
 (0)