Skip to content

NullPointerException on joining world (logged, not crash); 1.12.4, Client, Quilt #466

@ScoreUnder

Description

@ScoreUnder

if (FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
ClientPlayNetworking.registerGlobalReceiver(this.packetId, (payload, context) -> {
clientHandlers.get(endecsByClass.get(payload.message.getClass()).clientHandlerIndex).handle(payload.message, new ClientAccess(context.player().networkHandler));
});
}

Stack trace (deobfuscated on https://stackdeobf.net/):

[Render thread/ERROR]: Error executing task on Client
java.lang.NullPointerException: player
	at java.base/java.util.Objects.requireNonNull(Objects.java:259) ~[?:?]
	at net.fabricmc.fabric.impl.networking.client.ClientPlayNetworkAddon$ContextImpl.player(ClientPlayNetworkAddon.java:106) ~[fabric-networking-api-v1-4.4.0db5e668204.i0:0/:?]
	at io.wispforest.owo.network.OwoNetChannel.lambda$new$10(OwoNetChannel.java:164) ~[owo-0.12.201.21.4.i0:0/:?]
	at net.fabricmc.fabric.impl.networking.client.ClientPlayNetworkAddon.lambda$receive$0(ClientPlayNetworkAddon.java:73) ~[fabric-networking-api-v1-4.4.0db5e668204.i0:0/:?]
	at net.minecraft.util.thread.ThreadExecutor.executeTask(ThreadExecutor.java:164) [minecraft-1.21.4.i0:0/:?]
	at net.minecraft.util.thread.ReentrantThreadExecutor.executeTask(ReentrantThreadExecutor.java:23) [minecraft-1.21.4.i0:0/:?]
	at net.minecraft.util.thread.ThreadExecutor.runTask(ThreadExecutor.java:138) [minecraft-1.21.4.i0:0/:?]
	at net.minecraft.util.thread.ThreadExecutor.runTasks(ThreadExecutor.java:123) [minecraft-1.21.4.i0:0/:?]
	at net.minecraft.client.MinecraftClient.render(MinecraftClient.java:1296) [minecraft-1.21.4.i0:0/:?]
	at net.minecraft.client.MinecraftClient.run(MinecraftClient.java:922) [minecraft-1.21.4.i0:0/:?]
	at net.minecraft.client.main.Main.main(Main.java:267) [minecraft-1.21.4.i0:0/:?]
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?]
	at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?]
	at org.quiltmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:569) [quilt-loader-0.29.2.jar:?]
	at org.quiltmc.loader.impl.launch.knot.Knot.launch(Knot.java:85) [quilt-loader-0.29.2.jar:?]
	at org.quiltmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:28) [quilt-loader-0.29.2.jar:?]
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:115) [NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129) [NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) [NewLaunch.jar:?]

Essentially context.player() is null. This happens only once on server join. It's mostly a cosmetic issue but it would be nice to null-check it before getting the network handler object from it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions