CockroachDB: expand $getType() coverage in model adapter

[bpamiri]

Summary

CockroachDBModel only overrides $getType() for 4 type cases (bool, boolean, bit, varbit). Other CockroachDB-specific types may need explicit handling.

Details

• CockroachDB returns STRING for string columns (PostgreSQL returns varchar/text)
• JSONB handling may differ from PostgreSQL
• BYTES type (CockroachDB's binary) vs PostgreSQL's bytea
• INTERVAL, INET type handling
• Should verify full type introspection against a real CockroachDB instance

Files

• vendor/wheels/databaseAdapters/CockroachDB/CockroachDBModel.cfc — expand $getType() switch
• vendor/wheels/databaseAdapters/PostgreSQL/PostgreSQLModel.cfc:8-95 — inherited type map

[bpamiri]

Analysis

Synopsis

CockroachDBModel's $getType() only handles 4 type cases (bool, boolean, bit, varbit) and delegates everything else to PostgreSQL's $getType(). CockroachDB returns different type names in column metadata that may not match PostgreSQL's expectations.

Merit Assessment

Recommendation: Proceed with modifications

• The current implementation at CockroachDBModel.cfc:8-23 correctly handles the critical boolean difference and delegates to super.$getType() for all other types
• PostgreSQL's $getType() (PostgreSQLModel.cfc:8-95) already covers many types CockroachDB uses: int, int4, int8, bigint, float4, float8, varchar, text, jsonb, uuid, timestamp, timestamptz, bytea, inet, numeric, decimal, time, timetz
• The key question is: what type names does CockroachDB's JDBC metadata actually return? Without a running instance (CockroachDB: add to CI test matrix and Docker Compose #1973), this is speculative
• CockroachDB-specific types that PostgreSQL's handler may miss: STRING (native CockroachDB string type), BYTES (instead of bytea), INT2VECTOR, INTERVAL

Implementation Plan

1. Phase 1 (now): Add known CockroachDB-specific type mappings to CockroachDBModel.cfc:

   case "string":
       local.rv = "cf_sql_varchar";
       break;
   case "bytes":
       local.rv = "cf_sql_binary";
       break;
   case "int64":
       local.rv = "cf_sql_bigint";
       break;

2. Phase 2 (after CockroachDB: add to CI test matrix and Docker Compose #1973): Once CI has a running CockroachDB instance, run $dbinfo(type="columns") against test tables to capture the exact type names returned by CockroachDB's JDBC metadata. This will reveal exactly which types need handling.

3. Key file: vendor/wheels/databaseAdapters/CockroachDB/CockroachDBModel.cfc — expand the switch statement

4. Reference: vendor/wheels/databaseAdapters/PostgreSQL/PostgreSQLModel.cfc:8-95 — the fallback handler

5. Estimated complexity: Low for Phase 1, Medium for Phase 2 (requires empirical testing)

Dependencies & Risks

• Related: CockroachDB: define adapter-specific sqlTypes in migrator #1972 (sqlTypes in migrator must produce types that $getType() can read back — these two must be kept in sync), CockroachDB: add to CI test matrix and Docker Compose #1973 (essential for Phase 2 validation)
• Risk: Adding speculative type mappings without testing against a real CockroachDB instance could introduce false mappings. The super.$getType() delegation is actually a reasonable safety net.
• Recommendation: Keep the current delegation pattern (default: super.$getType()) and only add explicit overrides for types confirmed to differ from PostgreSQL's JDBC metadata. The PostgreSQL driver handles most of the heavy lifting since CockroachDB speaks the PostgreSQL wire protocol.
• Breaking change risk: None

---

Automated analysis by @claude — review and adjust as needed.