CockroachDB: add to CI test matrix and Docker Compose

[bpamiri]

Summary

CockroachDB is not in the CI test matrix or Docker Compose — the adapter is completely untested.

Details

• .github/workflows/tests.yml matrix: mysql,postgres,sqlserver,h2,oracle,sqlite — no CockroachDB
• compose.yml has no CockroachDB service
• No CockroachDB-specific test files in tests/

Needed

1. Add CockroachDB service to compose.yml (single-node, cockroachdb/cockroach:latest)
2. Add cockroachdb to test matrix in .github/workflows/tests.yml
3. Add datasource configuration for CockroachDB in test setup
4. Verify all existing tests pass against CockroachDB

Files

• .github/workflows/tests.yml:42 — test matrix
• compose.yml — Docker services

[bpamiri]

Analysis

Synopsis

CockroachDB is not in the CI test matrix or Docker Compose configuration — the adapter is completely untested in CI. The test matrix currently covers 6 databases (MySQL, PostgreSQL, SQL Server, H2, Oracle, SQLite) across 8 CFML engines.

Merit Assessment

Recommendation: Proceed — but defer until after #1970, #1971, #1972, and #1974 are resolved

• The CockroachDB adapter is currently 37 lines total across 2 files — it's the only adapter with zero CI coverage
• Without CI testing, bugs in CockroachDB: addPrimaryKeyOptions uses SERIAL (unsupported) #1970 and CockroachDB: $identitySelect may fail with unique_rowid() #1971 cannot be caught or verified as fixed
• This is the single most important issue for CockroachDB adapter quality — all other fixes are theoretical without it
• Adding CockroachDB to CI will increase CI time but CockroachDB single-node starts quickly (~5 seconds)

Implementation Plan

1. Add CockroachDB service to compose.yml:

   cockroachdb:
     image: cockroachdb/cockroach:latest
     command: start-single-node --insecure
     ports:
       - "26258:26257"
       - "8081:8080"
     healthcheck:
       test: ["CMD", "curl", "-f", "http://localhost:8080/health"]
       interval: 10s
       timeout: 5s
       retries: 5
       start_period: 15s
     networks:
       - wheels-network

2. Create the test database — CockroachDB needs an init step:

   • Add an init script or a startup command: cockroach sql --insecure -e "CREATE DATABASE IF NOT EXISTS wheelstestdb; CREATE USER IF NOT EXISTS wheelstestdb; GRANT ALL ON DATABASE wheelstestdb TO wheelstestdb;"
   • Alternatively, use an entrypoint script mounted as a volume

3. Add datasource to each engine's CFConfig.json (all 8 engine configs):

   "wheelstestdb_cockroachdb": {
       "class": "org.postgresql.Driver",
       "database": "wheelstestdb",
       "dbdriver": "PostgreSql",
       "dsn": "jdbc:postgresql://{host}:{port}/{database}",
       "host": "cockroachdb",
       "password": "",
       "port": "26257",
       "username": "wheelstestdb"
   }

   Note: CockroachDB uses the PostgreSQL wire protocol, so the PostgreSQL JDBC driver works.

4. Add cockroachdb to the database list in .github/workflows/tests.yml:42:

   • Add to the DATABASES variable in the db-list step
   • Add a readiness check in the "Wait for other databases" step
   • Update the matrix grid headers in test-matrix-summary

5. Update test runner to recognize cockroachdb as a valid db parameter and select the correct datasource name

6. Estimated complexity: Medium — touches many config files across 8 engine directories, plus workflow YAML

Dependencies & Risks

• Prerequisites: CockroachDB: addPrimaryKeyOptions uses SERIAL (unsupported) #1970, CockroachDB: $identitySelect may fail with unique_rowid() #1971, CockroachDB: define adapter-specific sqlTypes in migrator #1972, CockroachDB: expand $getType() coverage in model adapter #1974 should be done first — otherwise CI will just show failures for known bugs
• Risk: CockroachDB uses the PostgreSQL JDBC driver but reports database_productname as "CockroachDB" — need to verify the adapter detection logic in vendor/wheels/Model.cfc:399 works correctly with the Docker setup
• Risk: CI cost — adds ~5-10 minutes per engine (8 engines = 40-80 min additional). Consider making it optional or running only on specific engines initially (e.g., Lucee 6 only)
• Breaking change risk: None — additive CI change only

---

Automated analysis by @claude — review and adjust as needed.

[bpamiri]

Implemented: CockroachDB service in compose.yml, added to CI test matrix in tests.yml (was soft-fail, now promoted), adapter tests in place.