Issue with "hide all popovers until" algorithm

[nt1m]

To hide all popovers until, given an HTML element or Document endpoint, a boolean focusPreviousElement, and a boolean fireEvents:

1. Let document be endpoint's node document.
2. Let closeAllOpenPopovers be an algorithm which performs the following steps:
3. 1. Let popover be document's topmost auto popover.
4. 2. While popover is not null:
5. 2. 1. Run the hide popover algorithm given popover, focusPreviousElement, fireEvents, and false.
6. 2. 2. Set popover to document's topmost auto popover.
7. If endpoint is null, then run closeAllOpenPopovers and return.

So "endpoint" can be null, so how does steps 1. & 2. get the document? Does that algorithm need to always take a document as extra argument?

cc @josepharhar @mfreed7 @domenic

[annevk]

Is there a way to hit that step?

Thinking about this again I think @josepharhar fixed the call sites to always pass an element or a document. And then probably forgot to remove that step.

If true, that also means closeAllOpenPopovers can be inlined now.

[josepharhar]

Ah yes that was my mistake. It should be checking if endpoint is a document, not if endpoint is null. I opened a PR to fix it: #8966