chore: refine code

[weaponsforge]

Summary

• Fix: typo errors
• Chore: remove redundant code and set correct function return types
• Chore: exit early if no sender email is provided in sendEmail()

Related Issues

Type of Change

• Other (please describe): code and logic refinement

Checklist

• I have read the CONTRIBUTING.md
• My code follows the CODE STYLE of this project
• I have tested my changes locally

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Fixed OAuth2 authentication token configuration typo
  • Improved error handling in email sending operations

• New Features

  • Added validation for missing sender email configuration with clear error messages

• Documentation

  • Updated email subject field limit from 100 to 200 characters

• Improvements

  • Email send method now returns detailed message information instead of void

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 623520a7-25f3-4727-8616-4a1a3aec3fff

📥 Commits

Reviewing files that changed from the base of the PR and between 8949a8d and 507c886.

📒 Files selected for processing (8)

• app/src/__tests__/send.test.ts
• app/src/lib/email/sender.ts
• app/src/lib/email/transport.ts
• app/src/scripts/cli/lib/handleHtml.ts
• app/src/types/email.schema.ts
• app/src/types/schemavalidator.interface.ts
• app/src/types/sender.interface.ts
• app/src/types/transport.schema.ts

---

📝 Walkthrough

Walkthrough

This pull request introduces a typo fix for the OAuth2 refresh token property name across the codebase (googleRereshToken → googleRefreshToken), adds sender email validation with error handling, removes error-catching wrapper logic from HTML email handling, updates interface return types for email sending, and corrects schema documentation for subject field constraints.

Changes

Cohort / File(s)	Summary
OAuth2 Token Property Rename app/src/types/transport.schema.ts, app/src/lib/email/transport.ts, app/src/__tests__/send.test.ts	Corrects typo in OAuth2 refresh token field name from googleRereshToken to googleRefreshToken across schema definition, transport logic, and test fixtures.
Email Sender Validation & Return Type app/src/lib/email/sender.ts	Adds validation for sender email address with dedicated error message; derives from address from transport options or environment variable before attempting to send; updates method to provide send result to caller.
Interface & Type Updates app/src/types/sender.interface.ts, app/src/types/schemavalidator.interface.ts	Changes sendEmail return type from Promise<void> to Promise<SentMessageInfo> and updates getBaseSchema return type to remove null from union, making both contracts more explicit.
Schema Documentation & Error Handling app/src/types/email.schema.ts, app/src/scripts/cli/lib/handleHtml.ts	Updates subject field documentation to reflect 200-character maximum; removes surrounding try/catch wrapper from HTML email handler, allowing errors to propagate naturally.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• perf: update dependencies 20260327 #57: Modifies email sender logic for fallback sender address determination using process.env.GOOGLE_USER_EMAIL, directly overlapping with sender validation changes.
• feat: send styled html email from the cli #36: Updates handleHtml.ts handler implementation, related to error handling refactor in this PR.
• feat: send a styled HTML email #35: Modifies EmailSender implementation to add isHtml handling, intersecting with the return type and validation changes.

Poem

🐰 A token's typo fixed with care,
From Reresh to Refresh fair,
Validation blooms where errors grew,
No try-catch bounds, just truth shines through,
The sender claims their rightful place! 📧✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/refine-code

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}