Skip to content

chore: expand ESLint rules for stricter code style enforcement#62

Merged
weaponsforge merged 4 commits into
devfrom
chore/eslint-rules
Apr 16, 2026
Merged

chore: expand ESLint rules for stricter code style enforcement#62
weaponsforge merged 4 commits into
devfrom
chore/eslint-rules

Conversation

@weaponsforge
Copy link
Copy Markdown
Owner

@weaponsforge weaponsforge commented Apr 16, 2026

Summary

  • Added 6 new ESLint rules: keyword-spacing, no-multi-spaces, no-multiple-empty-lines, padding-line-between-statements, space-before-blocks, and @typescript-eslint/no-require-imports
  • Changed comma-dangle from 'never' to 'always-multiline' (trailing commas required on multiline structures)
  • Expanded @typescript-eslint/no-unused-vars to ignore variables/args prefixed with _; disabled the base no-unused-vars rule in favor of the TS-specific version
  • Applied all new rules across 27 source files (trailing commas, blank lines before return, spacing fixes)
  • Added and updated CLAUDE.md with accurate codebase documentation

Test plan

  • npm run lint passes with no errors
  • npm run transpile:noemit passes type-check
  • npm test passes all tests

Type of Change

  • Other (please describe): code styl

Checklist

- keyword-spacing: enforces spaces before/after keywords
- no-multi-spaces: disallows multiple consecutive spaces
- no-multiple-empty-lines: limits blank lines
- no-unused-vars: 'off': disables base rule (deferred to the TS-specific version)
- padding-line-between-statements: requires a blank line before every return statement
- space-before-blocks: enforces a space before { blocks
- @typescript-eslint/no-require-imports: disallows CommonJS require() calls
- @typescript-eslint/no-unused-vars: expanded config to ignore variables/args prefixed with underscore
- Rules object and array entries now use trailing commas
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

Warning

Rate limit exceeded

@weaponsforge has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 33 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 14 minutes and 33 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 01179e77-96c9-4ef4-82ad-65632a3bc8f3

📥 Commits

Reviewing files that changed from the base of the PR and between 264bb01 and d5b5386.

📒 Files selected for processing (29)
  • CLAUDE.md
  • app/eslint.config.mjs
  • app/src/__tests__/cli.test.ts
  • app/src/__tests__/oauth2client.test.ts
  • app/src/__tests__/sample.test.ts
  • app/src/__tests__/schemavalidator.test.ts
  • app/src/__tests__/send.test.ts
  • app/src/__tests__/sendFormat.test.ts
  • app/src/demo/sendEmail.ts
  • app/src/demo/sendHtml.ts
  • app/src/index.ts
  • app/src/lib/email/build.ts
  • app/src/lib/email/send.ts
  • app/src/lib/email/sender.ts
  • app/src/lib/email/transport.ts
  • app/src/lib/google/oauth2client.ts
  • app/src/lib/index.ts
  • app/src/lib/validator/schemavalidator.ts
  • app/src/scripts/build/copyTemplate.ts
  • app/src/scripts/cli/lib/handleHtml.ts
  • app/src/scripts/cli/lib/handleText.ts
  • app/src/scripts/cli/lib/meta.ts
  • app/src/scripts/cli/send.ts
  • app/src/types/email.schema.ts
  • app/src/types/oauth2client.interface.ts
  • app/src/types/oauth2client.schema.ts
  • app/src/utils/config/sanitizeHtml.ts
  • app/src/utils/helpers.ts
  • app/vite.config.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/eslint-rules

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@weaponsforge weaponsforge merged commit af42b8b into dev Apr 16, 2026
4 checks passed
@weaponsforge weaponsforge deleted the chore/eslint-rules branch April 16, 2026 02:25
@weaponsforge weaponsforge mentioned this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant