Skip to content

[ENHANCE] Add a parameter to kspaceFirstOrder() to control the data type that variables are cast to before computation #695

@WangKaifeng22

Description

@WangKaifeng22

Description of the Enhancement

Add a parameter to the latest API kspaceFirstOrder() to control the data type that variables are cast to before computation, and include relevant documentation.

Justification for the Enhancement

I'm excited that we can now use a unified API for simulations in the latest version! However, I noticed an issue: kspaceFirstOrder() lacks a parameter with the same functionality as data_cast in the SimulationOptions. The MATLAB version of k-Wave also has a parameter with this capability, which allows control over the data type that variables are cast before computation, helping us balance simulation accuracy and speed. Additionally, to my knowledge, the documentation does not explain how kspaceFirstOrder() handles the data types of variables.

Impact of Changes

kspaceFirstOrder()

Screenshots/Examples

Additional Context

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions