Skip to content

Commit 3fcdda7

Browse files
committed
chore: fix tests and lint
1 parent 513b691 commit 3fcdda7

8 files changed

Lines changed: 41 additions & 22 deletions

File tree

.github/workflows/quality.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
- name: Setup Biome
2424
uses: biomejs/setup-biome@v2
2525
with:
26-
version: latest
26+
version: 2.3.10
2727
- name: Run Biome
2828
run: biome ci
2929

apps/nextjs-15/src/app/parallel-routes/dashboard/page.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@ export default function DashboardPage() {
1010
<p>This is a static page with no dynamic params.</p>
1111

1212
<div
13-
style={{ marginTop: '1rem', padding: '1rem', backgroundColor: '#e3f2fd' }}
13+
style={{
14+
marginTop: '1rem',
15+
padding: '1rem',
16+
backgroundColor: '#e3f2fd',
17+
}}
1418
>
1519
<p>
1620
<strong>Path:</strong> {path}

apps/nextjs-15/src/app/parallel-routes/layout.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ export default function ParallelRoutesLayout({
99
}) {
1010
return (
1111
<div style={{ padding: '1rem' }}>
12-
<div style={{ display: 'grid', gridTemplateColumns: '1fr 2fr', gap: '1rem' }}>
12+
<div
13+
style={{ display: 'grid', gridTemplateColumns: '1fr 2fr', gap: '1rem' }}
14+
>
1315
<aside>{sidebar}</aside>
1416
<main>{children}</main>
1517
</div>

apps/nextjs-15/src/app/parallel-routes/settings/page.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@ export default function SettingsPage() {
1010
<p>This is a static page with no dynamic params.</p>
1111

1212
<div
13-
style={{ marginTop: '1rem', padding: '1rem', backgroundColor: '#e3f2fd' }}
13+
style={{
14+
marginTop: '1rem',
15+
padding: '1rem',
16+
backgroundColor: '#e3f2fd',
17+
}}
1418
>
1519
<p>
1620
<strong>Path:</strong> {path}

apps/nextjs/e2e/development/beforeSend.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,13 @@ test.describe('beforeSend', () => {
3535

3636
expect(
3737
messages.find((m) =>
38-
m.includes('[pageview] http://localhost:3000/before-send/first'),
38+
m.includes('[view] http://localhost:3000/before-send/first'),
3939
),
4040
).toBeDefined();
4141
expect(
4242
messages.find((m) =>
4343
m.includes(
44-
'[pageview] http://localhost:3000/before-send/second?secret=REDACTED',
44+
'[view] http://localhost:3000/before-send/second?secret=REDACTED',
4545
),
4646
),
4747
).toBeDefined();

apps/nextjs/e2e/development/pageview.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,12 @@ test.describe('pageview', () => {
3535

3636
expect(
3737
messages.find((m) =>
38-
m.includes('[pageview] http://localhost:3000/navigation/first'),
38+
m.includes('[view] http://localhost:3000/navigation/first'),
3939
),
4040
).toBeDefined();
4141
expect(
4242
messages.find((m) =>
43-
m.includes('[pageview] http://localhost:3000/navigation/second'),
43+
m.includes('[view] http://localhost:3000/navigation/second'),
4444
),
4545
).toBeDefined();
4646
});

apps/vue/index.html

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
11
<!DOCTYPE html>
2-
<html lang="">
3-
<head>
4-
<meta charset="UTF-8" />
5-
<link rel="icon" href="/favicon.ico" />
6-
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
7-
<title>Vite App</title>
8-
</head>
9-
<body>
10-
<div id="app"></div>
11-
<script type="module" src="/src/main.js"></script>
12-
</body>
13-
</html>
2+
<html lang="en">
3+
4+
<head>
5+
<meta charset="UTF-8" />
6+
<link rel="icon" href="/favicon.ico" />
7+
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
8+
<title>Vite App</title>
9+
</head>
10+
11+
<body>
12+
<div id="app"></div>
13+
<script type="module" src="/src/main.js"></script>
14+
</body>
15+
16+
</html>

packages/web/src/nextjs/utils.test.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
import { afterEach, describe, expect, it } from 'vitest';
2-
import { filterParallelRouteParams, getBasePath, getConfigString } from './utils';
2+
import {
3+
filterParallelRouteParams,
4+
getBasePath,
5+
getConfigString,
6+
} from './utils';
37

48
const processSave = { ...process };
59
const envSave = { ...process.env };
@@ -20,7 +24,9 @@ describe('parallel route slot param filtering', () => {
2024
const params = { slug: ['api', 'reference'] };
2125
// Next.js joins catch-all values with '/' in the router tree
2226
const segments = ['docs', 'api/reference'];
23-
expect(filterParallelRouteParams(params, segments)).toEqual({ slug: ['api', 'reference'] });
27+
expect(filterParallelRouteParams(params, segments)).toEqual({
28+
slug: ['api', 'reference'],
29+
});
2430
});
2531

2632
it('keeps string params and filters slot array params', () => {

0 commit comments

Comments
 (0)