From 3dcd4b3842f3458b2dd4c60930461745a3a2add3 Mon Sep 17 00:00:00 2001 From: Ulf Adams Date: Fri, 23 Jan 2026 20:59:05 +0100 Subject: [PATCH 1/2] Presubmit: run tests within test step, not benchmark Not sure how this happened, but I think this is better. --- .github/workflows/presubmit.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/presubmit.yml b/.github/workflows/presubmit.yml index 4b8c315..01926c6 100644 --- a/.github/workflows/presubmit.yml +++ b/.github/workflows/presubmit.yml @@ -37,6 +37,11 @@ jobs: - name: Test run: | bazel test //ryu/... //src/... + bazel test --copt=-DRYU_OPTIMIZE_SIZE //ryu/... + bazel test --copt=-DRYU_ONLY_64_BIT_OPS //ryu/... + bazel test --copt=-DRYU_OPTIMIZE_SIZE --copt=-DRYU_ONLY_64_BIT_OPS //ryu/... + bazel test --copt=-DRYU_FLOAT_FULL_TABLE //ryu/... + bazel test --copt=-DRYU_ONLY_64_BIT_OPS --copt=-DRYU_32_BIT_PLATFORM //ryu/... - name: Leak checker (macOS) if: matrix.os == 'macos-latest' && success() @@ -48,17 +53,13 @@ jobs: # machines are configured and what other things are run on the same # instances. - name: Benchmark + shell: ${{ runner.os == 'Windows' && 'cmd' || 'bash' }} run: | bazel run -c opt //ryu/benchmark:ryu_benchmark -- bazel run -c opt //ryu/benchmark:ryu_printf_benchmark -- -samples=200 - bazel test --copt=-DRYU_ONLY_64_BIT_OPS //ryu/... bazel run -c opt --copt=-DRYU_ONLY_64_BIT_OPS //ryu/benchmark:ryu_benchmark -- bazel run -c opt --copt=-DRYU_ONLY_64_BIT_OPS //ryu/benchmark:ryu_printf_benchmark -- -samples=200 - bazel test --copt=-DRYU_OPTIMIZE_SIZE //ryu/... bazel run -c opt --copt=-DRYU_OPTIMIZE_SIZE //ryu/benchmark:ryu_benchmark -- bazel run -c opt --copt=-DRYU_OPTIMIZE_SIZE //ryu/benchmark:ryu_printf_benchmark -- -samples=200 - bazel test --copt=-DRYU_OPTIMIZE_SIZE --copt=-DRYU_ONLY_64_BIT_OPS //ryu/... bazel run -c opt --copt=-DRYU_OPTIMIZE_SIZE --copt=-DRYU_ONLY_64_BIT_OPS //ryu/benchmark:ryu_benchmark bazel run -c opt --copt=-DRYU_OPTIMIZE_SIZE --copt=-DRYU_ONLY_64_BIT_OPS //ryu/benchmark:ryu_printf_benchmark -- -samples=200 - bazel test -c opt --copt=-DRYU_FLOAT_FULL_TABLE //ryu/... - bazel test -c opt --copt=-DRYU_ONLY_64_BIT_OPS --copt=-DRYU_32_BIT_PLATFORM //ryu/... From 2502b34fd90cf9fb6867dbe41b165b6c2a228153 Mon Sep 17 00:00:00 2001 From: Ulf Adams Date: Fri, 23 Jan 2026 21:39:40 +0100 Subject: [PATCH 2/2] Try bash --- .github/workflows/presubmit.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/presubmit.yml b/.github/workflows/presubmit.yml index 01926c6..e04cb36 100644 --- a/.github/workflows/presubmit.yml +++ b/.github/workflows/presubmit.yml @@ -53,7 +53,7 @@ jobs: # machines are configured and what other things are run on the same # instances. - name: Benchmark - shell: ${{ runner.os == 'Windows' && 'cmd' || 'bash' }} + shell: bash run: | bazel run -c opt //ryu/benchmark:ryu_benchmark -- bazel run -c opt //ryu/benchmark:ryu_printf_benchmark -- -samples=200