Merge pull request #103 from ubio/hotfix-stop-aux-server-on-app-stop

Hotfix stop aux server on app stop

Author: hyuko21

.env.test

@@ -1,5 +1,4 @@
 PORT=3000
 LOG_LEVEL=mute
 AC_JWKS_URL=http://auth.example.com
-ASSERT_CONFIGS_ON_START=false
-START_AUX_HTTP_SERVER_ON_START=false
+ASSERT_CONFIGS_ON_START=false

docs/metrics.md

@@ -69,7 +69,7 @@ In this example, `app_method_latencies_seconds{class="MyClass",method="doWork"}`
 
 ### Metrics endpoint
 
-By default, the application will run a http server (in a different port) that handles requests to `GET /metrics` endpoint, unless configured otherwise (i.e. `START_AUX_HTTP_SERVER_ON_START=false` is set). So, you don't have to do anything to expose the metrics reports.
+By default, the application will run a http server (in a different port) that handles requests to `GET /metrics` endpoint, unless configured otherwise (i.e. `START_AUX_HTTP_ON_START=false` is set). So, you don't have to do anything to expose the metrics reports.
 
 This endpoint reports metrics from all registered ones, which are:
 

src/main/application.ts

@@ -14,7 +14,7 @@ import { GlobalMetrics } from './metrics/global.js';
 export class Application extends BaseApp {
 
     @config({ default: false }) ASSERT_CONFIGS_ON_START!: boolean;
-    @config({ default: true }) START_AUX_HTTP_SERVER_ON_START!: boolean;
+    @config({ default: true }) START_AUX_HTTP_ON_START!: boolean;
 
     @dep() httpServer!: HttpServer;
     @dep() auxHttpServer!: AuxHttpServer;
@@ -47,14 +47,17 @@ export class Application extends BaseApp {
         if (this.ASSERT_CONFIGS_ON_START) {
             this.assertConfigs();
         }
-        if (this.START_AUX_HTTP_SERVER_ON_START) {
+        if (this.START_AUX_HTTP_ON_START) {
             await this.auxHttpServer.start();
         }
         await this.beforeStart();
     }
 
     override async stop() {
         await super.stop();
+        if (this.START_AUX_HTTP_ON_START) {
+            await this.auxHttpServer.stop();
+        }
         await this.afterStop();
     }