The GitHub Actions workflow for testing Trilogy would likely be faster and more maintainable if it used more GitHub Actions-native functionality. This would mean for the workflow to set up different services through GitHub Actions and use ruby/setup-ruby to run tests within a matrix.
The current GitHub Actions workflow uses Docker in the script/cibuild to build and run docker containers within the CI environment, which is slow and not the best use of GitHub Actions:
|
docker-compose rm -s -f -v |
|
output_fold "Pull cache image..." docker-compose pull app || true |
|
output_fold "Bootstrapping container..." docker-compose build |
|
output_fold "Running tests..." docker-compose run --rm app |
|
output_fold "Pushing cache image..." docker-compose push app || true # Don't fail if push fails |
The GitHub Actions workflow for testing Trilogy would likely be faster and more maintainable if it used more GitHub Actions-native functionality. This would mean for the workflow to set up different services through GitHub Actions and use
ruby/setup-rubyto run tests within a matrix.The current GitHub Actions workflow uses Docker in the
script/cibuildto build and run docker containers within the CI environment, which is slow and not the best use of GitHub Actions:trilogy/script/cibuild
Lines 53 to 57 in b11647a