Commit fe57bc5
committed
fix(webapp,sdk): address PR review nits
Four follow-up nits from the second-pass review on #3542.
.server-changes/sessions-dashboard-and-task-source-filter.md — adds
the missing high-level entry for the webapp surface (Sessions page +
task-source filter on Runs). The two existing changesets only cover
@trigger.dev/sdk and @trigger.dev/core, so the dashboard work
wouldn't have shown up in a future server changelog.
apps/webapp/app/routes/realtime.v1.sessions.$session.$io.records.ts
— switched `const loader = ...; export { loader }` to
`export const loader = ...` to match the sibling
`api.v1.deployments.current.ts` and the rest of the route file
convention. Functionally identical.
packages/core/src/v3/sessionStreams/manager.ts +
packages/core/src/v3/inputStreams/manager.ts — two clarifications:
(1) added a JSDoc to `disconnect()` documenting that it intentionally
leaves handlers and waiters in place, so any registered listener will
trigger an auto-reconnect with backoff. Distinguishes from `reset()`
(full clean state, rejects waiters) and `disconnectStream` (single
key, stays down until fresh `on()`/`once()`). (2) `disconnectStream`
now clears `reconnectAttempts` for the key — an explicit teardown is
not evidence of a broken backend, and a future re-attach should start
the backoff at attempt 0.1 parent 5359eda commit fe57bc5
4 files changed
Lines changed: 33 additions & 3 deletions
File tree
- .server-changes
- apps/webapp/app/routes
- packages/core/src/v3
- inputStreams
- sessionStreams
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
99 | | - | |
100 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
195 | 199 | | |
196 | 200 | | |
197 | 201 | | |
198 | 202 | | |
199 | 203 | | |
200 | 204 | | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
201 | 214 | | |
202 | 215 | | |
203 | 216 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
217 | 217 | | |
218 | 218 | | |
219 | 219 | | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
220 | 224 | | |
221 | 225 | | |
222 | 226 | | |
| |||
231 | 235 | | |
232 | 236 | | |
233 | 237 | | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
234 | 247 | | |
235 | 248 | | |
236 | 249 | | |
| |||
0 commit comments