Commit 710df37
committed
fix(webapp): tolerate missing task on locked + queue-override branch
Match main's pre-PR behavior — when a caller passes `lockToVersion` and a
queue override and the task slug isn't registered on that worker version,
fall through with `taskKind = undefined` (coalesced to "STANDARD"
downstream) and `taskTtl = undefined` instead of throwing.
This reverts the throw added earlier in this PR. The trade-off review
landed on "strict consistency check is better" twice (CodeRabbit
recommended it, Devin pushed back, we kept the throw) — but the net is
a behavioral change in the trigger API, and customers running
`lockToVersion` + a queue override against a slug that doesn't exist on
that version would start getting 4xx errors where they got silent
defaults before. Default-to-silent matches main and avoids the surprise.
The no-override branch keeps its throw because there's no queue to route
to in that case — the failure mode there is unrecoverable.1 parent b9fc87b commit 710df37
1 file changed
Lines changed: 9 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
121 | 128 | | |
122 | 129 | | |
123 | 130 | | |
124 | 131 | | |
125 | 132 | | |
126 | 133 | | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | 134 | | |
135 | | - | |
| 135 | + | |
136 | 136 | | |
137 | | - | |
| 137 | + | |
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
| |||
0 commit comments