Skip to content

Commit 0510fd6

Browse files
authored
ci: skip typecheck for refs and non-code file PRs (#3624)
Follow-up to #3615. The `code` filter currently fires typecheck for any change outside `docs/`, `.changeset/`, `hosting/`, or `.github/` - so a docs-only PR like #3623 (touching `references/ai-chat/.env.example` + `README.md`) triggered the typecheck job. None of the `references/*` packages declare a `typecheck` script either, so even when a real code change lands there, `turbo run typecheck` skips them. Running the job is pure cost. Tightens the filter to also exclude: - `references/**` - playground projects, none of them contribute to `turbo run typecheck` today - `**/*.md` - markdown anywhere - `**/.env.example` - example env files anywhere Two known gaps left open: - references/ have no real CI typecheck coverage. Separate question - either add `typecheck` scripts to each (or top-level `tsc -p`), or accept playground status. - `changes` job still runs (it's a path-filter step) but the dependent jobs all skip on irrelevant PRs.
1 parent e59291e commit 0510fd6

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

.github/workflows/pr_checks.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ jobs:
3434
- '!.changeset/**'
3535
- '!hosting/**'
3636
- '!.github/**'
37+
- '!references/**'
38+
- '!**/*.md'
39+
- '!**/.env.example'
3740
- '.github/workflows/pr_checks.yml'
3841
- '.github/workflows/typecheck.yml'
3942
webapp:

0 commit comments

Comments
 (0)