DVC pull: does not report SSH errors

[farhanhubble]

Bug Report

Issue name

dvc pull: does not report SSH errors

Description

When using SSH for remote storage, DVC fails to report ssh errors like missing key file, bad permission, incorrect username etc. and instead reports a generic hash not found / cloud download failed error.

Reproduce

1. dvc init
2. dvc remote add -d origin ssh://<username>@<URL><PATH>
3. dvc remote modify --local origin keyfile <path-to-your-private-key-file-with-wrong-permissions>
4. dvc pull -vv

Expected

Since DVC fails to reach the remote path because of an SSH error (private key with bad permissions), the error message should trace out the details.

Environment information

WSL / Linux

Output of dvc doctor:

$ dvc doctor

DVC version: 2.55.0 (pip)
-------------------------
Platform: Python 3.8.0 on Linux-5.10.102.1-microsoft-standard-WSL2-x86_64-with-glibc2.10
Subprojects:
        dvc_data = 0.47.5
        dvc_objects = 0.22.0
        dvc_render = 0.3.1
        dvc_task = 0.2.1
        scmrepo = 1.0.3
Supports:
        http (aiohttp = 3.8.4, aiohttp-retry = 2.8.3),
        https (aiohttp = 3.8.4, aiohttp-retry = 2.8.3),
        ssh (sshfs = 2023.4.1)
Cache types: hardlink, symlink
Cache directory: ext4 on /dev/sdc
Caches: local
Remotes: local, ssh
Workspace directory: ext4 on /dev/sdc
Repo: dvc, git
Repo.site_cache_dir: /var/tmp/dvc/repo/ca4100e2b07a11a8595ba5d1485eeff6

Additional Information (if any):

[efiop]

@farhanhubble Please post full verbose log of the error you are getting

[99-NinetyNine]

This issue is caused by the exception thrown
try:
user_ssh_config = parse_config(host=config["host"])
except:
print("yeah.. this FIleNotfounderror is only catching, #discussedBelow")
# except FileNotFoundError:
user_ssh_config = {}

#discussedBelow:
you see, exception is catching of type FileNotFound only. But later part of code has config.get("HostName") kind of logic. This is something design flaw.

For quick issue reslove,
change the line 56 as shown below.

[99-NinetyNine]

after debugging further, issue was in parameters passing.

add port as well, and solves the issue.

[shcheklein]

@99-NinetyNine can you create a PR for this please?