Add standalone activity startDelay support#2048
Merged
Merged
Conversation
THardy98
approved these changes
May 14, 2026
maciejdudko
requested changes
May 14, 2026
Contributor
maciejdudko
left a comment
maciejdudko
left a comment
There was a problem hiding this comment.
Looks good! The test needs different server setup (see comment) but otherwise LGTM!
Comment on lines
+183
to
+186
| executable: { | ||
| type: 'cached-download', | ||
| version: startDelayTestCliVersion, | ||
| }, |
Contributor
There was a problem hiding this comment.
This has very high chance of getting stale. Instead, use the default env that uses the existing server and update TESTS_CLI_VERSION and --dynamic-config-value in .github/workflows/ci.yml.
eamsden
force-pushed
the
ea/saa-delay-integration-test
branch
6 times, most recently
from
4ccac41 to
123dfa2
Compare
eamsden
force-pushed
the
ea/saa-delay-integration-test
branch
2 times, most recently
from
7b9b6c5 to
c547764
Compare
mjameswh
reviewed
May 22, 2026
maciejdudko
approved these changes
May 22, 2026
Wire ActivityOptions.startDelay into StartActivityExecutionRequest and validate that it is non-negative. Port the standalone activity delayed-start integration coverage from Python, including the server version/config needed to assert the scheduled-to-started delay.
eamsden
force-pushed
the
ea/saa-delay-integration-test
branch
from
577300d to
a34b13c
Compare
mjameswh
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire ActivityOptions.startDelay into StartActivityExecutionRequest and validate that it is non-negative.
Port the standalone activity delayed-start integration coverage from Python, including the server version/config needed to assert the scheduled-to-started delay.
What was changed
ActivityOptions.startDelayWhy?
Standalone activities now have a delayed-start feature. These changes expose this feature from the TS SDK
Checklist
Closes
How was this tested:
A new integration test was added and validated that new option has the desired effect of delaying the start of a standalone activity.
Any docs updates needed?
No.