fix(database): prevent infinite loop when creating a model with a has-one relationship

Author: Tom Nunn

packages/database/src/Builder/QueryBuilders/InsertQueryBuilder.php

@@ -289,11 +289,12 @@ private function handleStandardHasOneRelation(HasOne $hasOne, object|array $rela
         }
 
         // TODO: we might need to bake this into the naming strategy class
-        $foreignKeyColumn = Intl\singularize_last_word($ownerModel->getTableName()) . '_' . $ownerModel->getPrimaryKey();
+        $foreignKeyProperty = Intl\singularize_last_word($ownerModel->getTableName());
+        $foreignKeyColumn = $foreignKeyProperty . '_' . $ownerModel->getPrimaryKey();
 
         $preparedData = is_array($relation)
             ? [...$relation, ...[$foreignKeyColumn => $parentId->value]]
-            : [...$this->convertObjectToArray($relation), ...[$foreignKeyColumn => $parentId->value]];
+            : [...$this->convertObjectToArray($relation, [$foreignKeyProperty]), ...[$foreignKeyColumn => $parentId->value]];
 
         $relatedModelQuery = new InsertQueryBuilder(
             model: $hasOne->property->getType()->asClass(),

tests/Integration/Database/Builder/IsDatabaseModelTest.php

@@ -187,6 +187,8 @@ public function test_create_with_hasone_relation(): void
     {
         $this->database->migrate(
             CreateMigrationsTable::class,
+            CreatePublishersTable::class,
+            CreateAuthorTable::class,
             CreateBookTable::class,
             CreateIsbnTable::class,
         );