Skip to content

Commit 42fc8b3

Browse files
krodakkrodak
authored
Merge pull request #531 from PassiveLogic/krodak/silence-warnings
BridgeJS: Use let for non-mutated __bjs_self in generated toJSObject()
2 parents 57160fe + d3c6d53 commit 42fc8b3

6 files changed

Lines changed: 25 additions & 25 deletions

File tree

‎Benchmarks/Sources/Generated/BridgeJS.swift‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ extension SimpleStruct: _BridgedSwiftStruct {
277277
}
278278

279279
func toJSObject() -> JSObject {
280-
var __bjs_self = self
280+
let __bjs_self = self
281281
__bjs_self.bridgeJSLowerReturn()
282282
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_SimpleStruct()))
283283
}
@@ -330,7 +330,7 @@ extension Address: _BridgedSwiftStruct {
330330
}
331331

332332
func toJSObject() -> JSObject {
333-
var __bjs_self = self
333+
let __bjs_self = self
334334
__bjs_self.bridgeJSLowerReturn()
335335
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_Address()))
336336
}
@@ -389,7 +389,7 @@ extension Person: _BridgedSwiftStruct {
389389
}
390390

391391
func toJSObject() -> JSObject {
392-
var __bjs_self = self
392+
let __bjs_self = self
393393
__bjs_self.bridgeJSLowerReturn()
394394
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_Person()))
395395
}
@@ -451,7 +451,7 @@ extension ComplexStruct: _BridgedSwiftStruct {
451451
}
452452

453453
func toJSObject() -> JSObject {
454-
var __bjs_self = self
454+
let __bjs_self = self
455455
__bjs_self.bridgeJSLowerReturn()
456456
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_ComplexStruct()))
457457
}

‎Plugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1179,7 +1179,7 @@ struct StructCodegen {
11791179
}
11801180
11811181
\(raw: accessControl)func toJSObject() -> JSObject {
1182-
var __bjs_self = self
1182+
let __bjs_self = self
11831183
__bjs_self.bridgeJSLowerReturn()
11841184
return JSObject(id: UInt32(bitPattern: \(raw: raiseFunctionName)()))
11851185
}

‎Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/ExportSwiftTests/DefaultParameters.swift‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ extension Config: _BridgedSwiftStruct {
6363
}
6464

6565
func toJSObject() -> JSObject {
66-
var __bjs_self = self
66+
let __bjs_self = self
6767
__bjs_self.bridgeJSLowerReturn()
6868
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_Config()))
6969
}
@@ -106,7 +106,7 @@ extension MathOperations: _BridgedSwiftStruct {
106106
}
107107

108108
func toJSObject() -> JSObject {
109-
var __bjs_self = self
109+
let __bjs_self = self
110110
__bjs_self.bridgeJSLowerReturn()
111111
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_MathOperations()))
112112
}

‎Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/ExportSwiftTests/SwiftStruct.swift‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ extension DataPoint: _BridgedSwiftStruct {
3636
}
3737

3838
func toJSObject() -> JSObject {
39-
var __bjs_self = self
39+
let __bjs_self = self
4040
__bjs_self.bridgeJSLowerReturn()
4141
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_DataPoint()))
4242
}
@@ -104,7 +104,7 @@ extension Address: _BridgedSwiftStruct {
104104
}
105105

106106
func toJSObject() -> JSObject {
107-
var __bjs_self = self
107+
let __bjs_self = self
108108
__bjs_self.bridgeJSLowerReturn()
109109
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_Address()))
110110
}
@@ -163,7 +163,7 @@ extension Person: _BridgedSwiftStruct {
163163
}
164164

165165
func toJSObject() -> JSObject {
166-
var __bjs_self = self
166+
let __bjs_self = self
167167
__bjs_self.bridgeJSLowerReturn()
168168
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_Person()))
169169
}
@@ -208,7 +208,7 @@ extension Session: _BridgedSwiftStruct {
208208
}
209209

210210
func toJSObject() -> JSObject {
211-
var __bjs_self = self
211+
let __bjs_self = self
212212
__bjs_self.bridgeJSLowerReturn()
213213
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_Session()))
214214
}
@@ -250,7 +250,7 @@ extension ConfigStruct: _BridgedSwiftStruct {
250250
}
251251

252252
func toJSObject() -> JSObject {
253-
var __bjs_self = self
253+
let __bjs_self = self
254254
__bjs_self.bridgeJSLowerReturn()
255255
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_ConfigStruct()))
256256
}

‎Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/ExportSwiftTests/UnsafePointer.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ extension PointerFields: _BridgedSwiftStruct {
2525
}
2626

2727
func toJSObject() -> JSObject {
28-
var __bjs_self = self
28+
let __bjs_self = self
2929
__bjs_self.bridgeJSLowerReturn()
3030
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_PointerFields()))
3131
}

‎Tests/BridgeJSRuntimeTests/Generated/BridgeJS.swift‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2239,7 +2239,7 @@ extension PointerFields: _BridgedSwiftStruct {
22392239
}
22402240

22412241
func toJSObject() -> JSObject {
2242-
var __bjs_self = self
2242+
let __bjs_self = self
22432243
__bjs_self.bridgeJSLowerReturn()
22442244
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_PointerFields()))
22452245
}
@@ -2312,7 +2312,7 @@ extension DataPoint: _BridgedSwiftStruct {
23122312
}
23132313

23142314
func toJSObject() -> JSObject {
2315-
var __bjs_self = self
2315+
let __bjs_self = self
23162316
__bjs_self.bridgeJSLowerReturn()
23172317
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_DataPoint()))
23182318
}
@@ -2380,7 +2380,7 @@ extension Address: _BridgedSwiftStruct {
23802380
}
23812381

23822382
func toJSObject() -> JSObject {
2383-
var __bjs_self = self
2383+
let __bjs_self = self
23842384
__bjs_self.bridgeJSLowerReturn()
23852385
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_Address()))
23862386
}
@@ -2445,7 +2445,7 @@ extension Contact: _BridgedSwiftStruct {
24452445
}
24462446

24472447
func toJSObject() -> JSObject {
2448-
var __bjs_self = self
2448+
let __bjs_self = self
24492449
__bjs_self.bridgeJSLowerReturn()
24502450
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_Contact()))
24512451
}
@@ -2508,7 +2508,7 @@ extension Config: _BridgedSwiftStruct {
25082508
}
25092509

25102510
func toJSObject() -> JSObject {
2511-
var __bjs_self = self
2511+
let __bjs_self = self
25122512
__bjs_self.bridgeJSLowerReturn()
25132513
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_Config()))
25142514
}
@@ -2557,7 +2557,7 @@ extension SessionData: _BridgedSwiftStruct {
25572557
}
25582558

25592559
func toJSObject() -> JSObject {
2560-
var __bjs_self = self
2560+
let __bjs_self = self
25612561
__bjs_self.bridgeJSLowerReturn()
25622562
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_SessionData()))
25632563
}
@@ -2614,7 +2614,7 @@ extension ValidationReport: _BridgedSwiftStruct {
26142614
}
26152615

26162616
func toJSObject() -> JSObject {
2617-
var __bjs_self = self
2617+
let __bjs_self = self
26182618
__bjs_self.bridgeJSLowerReturn()
26192619
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_ValidationReport()))
26202620
}
@@ -2657,7 +2657,7 @@ extension MathOperations: _BridgedSwiftStruct {
26572657
}
26582658

26592659
func toJSObject() -> JSObject {
2660-
var __bjs_self = self
2660+
let __bjs_self = self
26612661
__bjs_self.bridgeJSLowerReturn()
26622662
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_MathOperations()))
26632663
}
@@ -2753,7 +2753,7 @@ extension CopyableCart: _BridgedSwiftStruct {
27532753
}
27542754

27552755
func toJSObject() -> JSObject {
2756-
var __bjs_self = self
2756+
let __bjs_self = self
27572757
__bjs_self.bridgeJSLowerReturn()
27582758
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_CopyableCart()))
27592759
}
@@ -2812,7 +2812,7 @@ extension CopyableCartItem: _BridgedSwiftStruct {
28122812
}
28132813

28142814
func toJSObject() -> JSObject {
2815-
var __bjs_self = self
2815+
let __bjs_self = self
28162816
__bjs_self.bridgeJSLowerReturn()
28172817
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_CopyableCartItem()))
28182818
}
@@ -2863,7 +2863,7 @@ extension CopyableNestedCart: _BridgedSwiftStruct {
28632863
}
28642864

28652865
func toJSObject() -> JSObject {
2866-
var __bjs_self = self
2866+
let __bjs_self = self
28672867
__bjs_self.bridgeJSLowerReturn()
28682868
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_CopyableNestedCart()))
28692869
}
@@ -2922,7 +2922,7 @@ extension ConfigStruct: _BridgedSwiftStruct {
29222922
}
29232923

29242924
func toJSObject() -> JSObject {
2925-
var __bjs_self = self
2925+
let __bjs_self = self
29262926
__bjs_self.bridgeJSLowerReturn()
29272927
return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_ConfigStruct()))
29282928
}

0 commit comments

Comments
 (0)