Skip to content

fix: skip server start when STATIC_HTML_SERVER_URL is set #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Svtter merged 2 commits into from
May 15, 2026
Merged

fix: skip server start when STATIC_HTML_SERVER_URL is set #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f674c42
fix: skip server start when STATIC_HTML_SERVER_URL is set
May 15, 2026
79839fd
fix: quote $STATIC_HTML_SERVER_URL in echo to prevent word splitting
May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion skills/sth/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ This script:
- otherwise clones or updates `sun-praise/static-html`
- builds `dist/sth` when the Go source fingerprint changes

2. Start the preview server:
2. Start the preview server **only if not already running**:

If `STATIC_HTML_SERVER_URL` is set (e.g. the server is already deployed elsewhere), skip this step entirely.

Otherwise start locally:

```bash
bash scripts/start-server.sh [port]
Expand Down
6 changes: 6 additions & 0 deletions skills/sth/scripts/start-server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

set -euo pipefail

# If an external server is already configured, skip starting a local one.
if [ -n "${STATIC_HTML_SERVER_URL:-}" ]; then
echo "STATIC_HTML_SERVER_URL is set ($STATIC_HTML_SERVER_URL) — skipping server start." >&2
exit 0
fi

script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
repo_dir="$("$script_dir/bootstrap-repo.sh")"
host="${STATIC_HTML_HOST:-0.0.0.0}"
Expand Down
Loading