Add theming, app icon, and Obsidian parity foundations#5
Merged
Conversation
ace28bd to
191cb04
Compare
There was a problem hiding this comment.
lipstyk found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[publication]frontmatter writes, local preview export command/report modal, and publication adapter contract docs..flynt/bookmarks.toml, sidebar bookmark list, note/search bookmark commands, saved-search route restore, and store round-trip tests..flynt/lenses/*.tomldefinitions, live document/task lens execution over existing store APIs, a read-only Lenses route, andSave Search as Lens.Validation
cargo check -p flynt-agent -p flynt-app -p flynt-core -p flynt-storecargo test -p flynt-store -p flynt-core -p flynt-agentcargo check -p flynt-app -p flynt-storecargo test -p flynt-store publication -- --nocapturecargo check -p flynt-app -p flynt-storecargo test -p flynt-store bookmarks -- --nocapturecargo check -p flynt-app -p flynt-store -p flynt-corecargo test -p flynt-core lens -- --nocapturecargo test -p flynt-store lenses -- --nocapturecargo check -p flynt-appcargo test -p flynt-app note_preview -- --nocapturegit diff --checkpython3 scripts/generate-icons.py,python3 -m py_compile scripts/generate-icons.py,cargo check -p flynt-app,cargo test -p flynt-app theme::Notes
This draft is rebased onto current
main, including the merged MCP/tab latency hotfix from #19.OP-07 graph hover previews and visual e2e smoke are still marked as follow-up work in the parity milestone.