PasswordGrantAuthenticator is broken in 2.4.1

[pwiatrowski]

Hi,

in the most recent version I cannot use PasswordGrantAuthenticator anymore.
when I try to authenticate using:
authenticator = PasswordGrantAuthenticator(sp_application)
result = authenticator.authenticate(email, password)

the result is always None - even with the correct credentials.

[rdegges]

Looking into this right now. All the tests are still passing, which worries me a bit.

[rdegges]

I found out where the issue is located, am working on a fix. Basically: something is up with the HTTPExecutor when using the SAuthc1 authentication strategy. It is working fine w/ basic auth right now.

When we send the passwordgrant request in the new release, we do so in a more secure way than before (we post our data to the server instead of sending it via query params). This required me to add an additional header to the post request that was being made: to tell the server we have form encoded data (per the oauth2 spec).

This is apparently causing breakage using our secure header library, which is why the tests did not catch it (they are using basic auth).

If you want an immediately fix, either downgrade the library, or do the following when initializing your client:

client = Client(id='xxx', secret='xxx', scheme='basic')

That will fix it immediately. I'm working on a fix for this now. Thanks for the report!!

[pwiatrowski]

Thanks for such a quick reply!

As a temporary solution I downgraded the library and will wait for the fix.

Cheers!

[rdegges]

@sasakalaba would you mind taking a look at this during the week?

[Kaleidophon]

This is exactly what I looked for! Could be please add a remark to your documentation as long as this problem remains unfixed?

[Kaleidophon]

Also maybe to your stackoverflow answer here (I was using it as a template and going nuts because it wasn't working).

[rdegges]

Hey guys, quick update. This is still in progress. It's a much more difficult bug to fix than it appears. We're working on figuring out exactly why the underlying SAuthC1 algorithm is causing issues here.

[elad]

@rdegges we just got bit by this as well. Using the scheme='basic' workaround works. However, we're unable to specify a directory for account_store. Is it supposed to work...?