From 6c32a9ef85a44fb1785cb87e8f6ad0af7bae0fd2 Mon Sep 17 00:00:00 2001 From: Dimitrios Pantazis Date: Thu, 21 May 2026 17:52:39 +0300 Subject: [PATCH 1/3] fix: dropped typehint from wp attached callback --- src/Harbor/Admin/Feature_Manager_Page.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Harbor/Admin/Feature_Manager_Page.php b/src/Harbor/Admin/Feature_Manager_Page.php index 4e11f235..f0cf448a 100644 --- a/src/Harbor/Admin/Feature_Manager_Page.php +++ b/src/Harbor/Admin/Feature_Manager_Page.php @@ -128,12 +128,13 @@ public function maybe_register_page(): void { * the React bundle is loaded only on this specific admin page. * * @since 1.0.0 + * @since TBD Dropped string typehint for $hook_suffix. * * @param string $hook_suffix Current admin page hook suffix. * * @return void */ - public function maybe_enqueue_assets( string $hook_suffix ): void { + public function maybe_enqueue_assets( $hook_suffix ): void { if ( $hook_suffix !== $this->page_hook ) { return; } From bb972184edbfc0dd84ed1994b4f0e09747ff2558 Mon Sep 17 00:00:00 2001 From: Dimitrios Pantazis Date: Thu, 21 May 2026 18:02:59 +0300 Subject: [PATCH 2/3] chore: added changelog --- changelog/fix-drop-type-hint-from-wp-callback.yaml | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 changelog/fix-drop-type-hint-from-wp-callback.yaml diff --git a/changelog/fix-drop-type-hint-from-wp-callback.yaml b/changelog/fix-drop-type-hint-from-wp-callback.yaml new file mode 100644 index 00000000..854856b1 --- /dev/null +++ b/changelog/fix-drop-type-hint-from-wp-callback.yaml @@ -0,0 +1,4 @@ +significance: patch +type: fix +entry: Typehint in WP Core's callback was too strict and could cause fatal. +timestamp: 2026-05-21T15:02:34.497Z From ba34628cb3d9bcf8b3b0dc3f6678f621e25bc208 Mon Sep 17 00:00:00 2001 From: Dimitrios Pantazis Date: Thu, 21 May 2026 18:09:34 +0300 Subject: [PATCH 3/3] chore: spelling issues --- changelog/fix-drop-type-hint-from-wp-callback.yaml | 2 +- src/Harbor/Admin/Feature_Manager_Page.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/changelog/fix-drop-type-hint-from-wp-callback.yaml b/changelog/fix-drop-type-hint-from-wp-callback.yaml index 854856b1..a70ce4aa 100644 --- a/changelog/fix-drop-type-hint-from-wp-callback.yaml +++ b/changelog/fix-drop-type-hint-from-wp-callback.yaml @@ -1,4 +1,4 @@ significance: patch type: fix -entry: Typehint in WP Core's callback was too strict and could cause fatal. +entry: Type-hint in WP Core's callback was too strict and could cause fatal. timestamp: 2026-05-21T15:02:34.497Z diff --git a/src/Harbor/Admin/Feature_Manager_Page.php b/src/Harbor/Admin/Feature_Manager_Page.php index f0cf448a..142f07c8 100644 --- a/src/Harbor/Admin/Feature_Manager_Page.php +++ b/src/Harbor/Admin/Feature_Manager_Page.php @@ -128,7 +128,7 @@ public function maybe_register_page(): void { * the React bundle is loaded only on this specific admin page. * * @since 1.0.0 - * @since TBD Dropped string typehint for $hook_suffix. + * @since TBD Dropped string type-hint for $hook_suffix. * * @param string $hook_suffix Current admin page hook suffix. *