fix: accept first click in Codex account switcher#1079
Merged
Conversation
This was referenced May 21, 2026
Override acceptsFirstMouse, swallow child hit testing, and implement mouseDown/mouseUp with correct coordinate space conversion for multi-row account layouts.
Root cause: the runtime-click tests synthesized hit points before NSStackView laid out the switcher rows, so every button still sat at {0,0} and the simulated click always resolved to the first account.
Split from steipete#1073.
steipete
force-pushed
the
fix/switcher-first-click
branch
from
5318b2c to
49a1edb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix first-click acceptance in the Codex account switcher for menu bar
popovers that aren't key windows.
Split from #1073 per review feedback.
Not included
Problem
The plain NSButton inside CodexAccountSwitcherView dropped the first
click because the menu popover wasn't key.
Root cause of test failure: the runtime-click tests synthesized hit
points before NSStackView laid out the switcher rows, so every button
still sat at {0,0} and the simulated click always resolved to the
first account.
Changes
acceptsFirstMouse(for:)→truemouseDown/mouseUpwith correct coordinate space conversion for multi-row layoutsTesting
swift test --filter StatusMenuCodexSwitcherTests✅ — all tests pass, including multi-row click targeting