Skip to content

Commit fe4e15f

Browse files
committed
fix(ci): remove useless test step and lint-go job, adjust go build matrix
- we only support the latest two go version - test step only tested generated tests, which do not exist - lint-go job removed waiters to prevent build failures on typecheck errors. This breaks typecheck in examples. Removing examples would need editing of go.work file before linting. - linting was called with `skip-non-generated-files=true`, but golangci-lint skips generated files by default. So this job linted nothing.
1 parent 2c9c6be commit fe4e15f

1 file changed

Lines changed: 1 addition & 50 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 1 addition & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
strategy:
1313
matrix:
1414
os: [ubuntu-latest, macos-latest]
15-
go-version: ["1.21", "1.22", "1.23"]
15+
go-version: ["1.25", "1.26"]
1616
runs-on: ${{ matrix.os }}
1717
steps:
1818
- name: Install Java
@@ -40,55 +40,6 @@ jobs:
4040
- name: Generate SDK
4141
shell: bash
4242
run: make generate-go-sdk
43-
44-
- name: Test
45-
working-directory: ./sdk-repo-updated
46-
run: make test skip-non-generated-files=true
47-
48-
lint-go:
49-
name: CI [Go]
50-
strategy:
51-
matrix:
52-
os: [ubuntu-latest, macos-latest]
53-
runs-on: ${{ matrix.os }}
54-
steps:
55-
- name: Install Java
56-
uses: actions/setup-java@v4
57-
with:
58-
distribution: "temurin"
59-
java-version: ${{ env.JAVA_VERSION }}
60-
61-
- name: Checkout
62-
uses: actions/checkout@v4
63-
64-
- name: Install Go
65-
uses: actions/setup-go@v5
66-
with:
67-
go-version: ${{ env.GO_VERSION_BUILD }}
68-
69-
- name: Install project tools and dependencies
70-
shell: bash
71-
run: make project-tools
72-
73-
- name: Download OAS
74-
shell: bash
75-
run: make download-oas
76-
77-
- name: Generate SDK
78-
shell: bash
79-
run: make generate-go-sdk
80-
81-
- name: Remove waiters
82-
working-directory: ./sdk-repo-updated
83-
run: rm -r services/*/wait
84-
85-
- name: Install SDK project tools and dependencies
86-
working-directory: ./sdk-repo-updated
87-
run: make project-tools
88-
89-
- name: Lint
90-
working-directory: ./sdk-repo-updated
91-
run: make lint skip-non-generated-files=true
9243

9344
main-python:
9445
name: CI [Python]

0 commit comments

Comments
 (0)