Misleading shorthand flag panic message

[mdhender]

Adding a BoolVarP with shorthand code of "h" to any flagset generates a misleading panic message:

panic: unable to redefine 'h' shorthand in "mapgen" flagset: it's already used for "flag" flag

The error makes it seem like the issue is with the "mapgen" flagset (in this example) when it's actually from the default help flagset.

To recreate, add a BoolVarP to the root command and then run the command with no arguments.

var flag bool
func init() {
	rootCmd.Flags().BoolVarP(&flag, "flag", "h", false, "flag")
}

This is with v1.0.5.

[marckhouzam]

This sounds like a good thing to improve. PR welcomed.

[roshanavand]

This message is coming from the pflag library, I created a PR here.

[marckhouzam]

Thanks @roshanavand !
Let's close this one in favor of the other.