Skip to content

[E2E Test] Two-phase review (e2e-two-phase-test-d62575cd) #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sourya-deepsource wants to merge 1 commit into from
Closed

[E2E Test] Two-phase review (e2e-two-phase-test-d62575cd) #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions e2e_test_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import os
import subprocess
import ssl

AWS_SECRET_KEY = "d6s$f9g!j8mg7hw?n&2"
Copy link
Copy Markdown
Owner Author

@sourya-deepsource sourya-deepsource Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded AWS secret key found in source code


Storing secrets like AWS_SECRET_KEY directly in source code is a security risk. Use environment variables or a secrets manager instead.



class BaseNumberGenerator:
"""Declare a method -- `get_number`."""

def __init__(self):
self.limits = (1, 10)

def get_number(self, min_max):
raise NotImplemented
Copy link
Copy Markdown
Owner Author

@sourya-deepsource sourya-deepsource Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use `NotImplementedError` instead of `NotImplemented`


NotImplemented is a special singleton used for binary operator fallbacks, not for signalling unimplemented methods. Raise NotImplementedError instead.


@staticmethod
def smethod():
"""static method."""
Loading