Skip to content

Commit edff17f

Browse files
fix: upgrade simple-git to 3.36.0 to address CVE-2026-6951
Fixes SOU-1032 Updates simple-git from 3.33.0 to 3.36.0 in both @sourcebot/backend and @sourcebot/web packages to patch a Remote Code Execution vulnerability where attackers could bypass the CVE-2022-25912 fix by using --config instead of -c flag. Code review confirmed that user-controlled inputs are already safely handled (passed as string arguments rather than in options objects), providing defense-in-depth alongside this upgrade. Co-authored-by: Brendan Kellam <brendan@sourcebot.dev>
1 parent 3e68b32 commit edff17f

3 files changed

Lines changed: 26 additions & 8 deletions

File tree

packages/backend/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"posthog-node": "^5.24.15",
5454
"prom-client": "^15.1.3",
5555
"redlock": "5.0.0-beta.2",
56-
"simple-git": "^3.33.0",
56+
"simple-git": "^3.36.0",
5757
"zod": "^3.25.74"
5858
}
5959
}

packages/web/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@
183183
"scroll-into-view-if-needed": "^3.1.0",
184184
"server-only": "^0.0.1",
185185
"sharp": "^0.33.5",
186-
"simple-git": "^3.33.0",
186+
"simple-git": "^3.36.0",
187187
"slate": "^0.117.0",
188188
"slate-dom": "^0.116.0",
189189
"slate-history": "^0.113.1",

yarn.lock

Lines changed: 24 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8047,6 +8047,22 @@ __metadata:
80478047
languageName: node
80488048
linkType: hard
80498049

8050+
"@simple-git/args-pathspec@npm:^1.0.3":
8051+
version: 1.0.3
8052+
resolution: "@simple-git/args-pathspec@npm:1.0.3"
8053+
checksum: 10c0/91bfc99daa956df28e4efd683cd799f60c6d169fce6adf71a9efa80a6b5938fed4b03e55fa929cfd51aed64f3ada5c1e4edad45a3872dbd94d11924b3258b5bc
8054+
languageName: node
8055+
linkType: hard
8056+
8057+
"@simple-git/argv-parser@npm:^1.1.0":
8058+
version: 1.1.1
8059+
resolution: "@simple-git/argv-parser@npm:1.1.1"
8060+
dependencies:
8061+
"@simple-git/args-pathspec": "npm:^1.0.3"
8062+
checksum: 10c0/2c21166f1bb7c4373e7b4e52bd0c7f333e58ea0ff5ac0b6c2d305835f4a2bcad1ef4bcce3cff63312ac55655ea7be3aba4c7c0c41e3ebcb8bee343f65bb92f5e
8063+
languageName: node
8064+
linkType: hard
8065+
80508066
"@smithy/config-resolver@npm:^4.4.17":
80518067
version: 4.4.17
80528068
resolution: "@smithy/config-resolver@npm:4.4.17"
@@ -8633,7 +8649,7 @@ __metadata:
86338649
posthog-node: "npm:^5.24.15"
86348650
prom-client: "npm:^15.1.3"
86358651
redlock: "npm:5.0.0-beta.2"
8636-
simple-git: "npm:^3.33.0"
8652+
simple-git: "npm:^3.36.0"
86378653
tsc-watch: "npm:^6.2.0"
86388654
tsx: "npm:^4.21.0"
86398655
typescript: "npm:^5.6.2"
@@ -8924,7 +8940,7 @@ __metadata:
89248940
scroll-into-view-if-needed: "npm:^3.1.0"
89258941
server-only: "npm:^0.0.1"
89268942
sharp: "npm:^0.33.5"
8927-
simple-git: "npm:^3.33.0"
8943+
simple-git: "npm:^3.36.0"
89288944
slate: "npm:^0.117.0"
89298945
slate-dom: "npm:^0.116.0"
89308946
slate-history: "npm:^0.113.1"
@@ -20394,14 +20410,16 @@ __metadata:
2039420410
languageName: node
2039520411
linkType: hard
2039620412

20397-
"simple-git@npm:^3.33.0":
20398-
version: 3.33.0
20399-
resolution: "simple-git@npm:3.33.0"
20413+
"simple-git@npm:^3.36.0":
20414+
version: 3.36.0
20415+
resolution: "simple-git@npm:3.36.0"
2040020416
dependencies:
2040120417
"@kwsites/file-exists": "npm:^1.1.1"
2040220418
"@kwsites/promise-deferred": "npm:^1.1.1"
20419+
"@simple-git/args-pathspec": "npm:^1.0.3"
20420+
"@simple-git/argv-parser": "npm:^1.1.0"
2040320421
debug: "npm:^4.4.0"
20404-
checksum: 10c0/463e91f3ee04b7fc445284c64502a4ee3d607f626f18c8bcc036815a30fe178d2216976e683c6368edd7b3093801d6e534deeb8e700a4863a76ef23f881a0712
20422+
checksum: 10c0/4c22e57107535168f354e5abbbf6e618a7b39d76491ca225c70588520fbe86891f3b9a5c4f8a3fc0137e669aad2f0e11f6c6e677bfec07169cd18f29bf23cb77
2040520423
languageName: node
2040620424
linkType: hard
2040720425

0 commit comments

Comments
 (0)