Skip to content

#19 Fix publish command#20

Merged
magiino merged 7 commits into
mainfrom
19-fix-publish-command
Jan 5, 2026
Merged

#19 Fix publish command#20
magiino merged 7 commits into
mainfrom
19-fix-publish-command

Conversation

@magiino
Copy link
Copy Markdown
Contributor

@magiino magiino commented Jan 2, 2026

Issue number

#19

Changes

Please review PR by individual commits.

The publish command now compares the last two commits (HEAD~1 and HEAD) instead of comparing the last commit with the working tree to determine which projects were published.
This change is required because publishing must be done after version bumps and generated files are committed. Since there is no other reliable way to detect whether the version command was run before publish, the comparison must be based on committed changes.

Also last 5 code scanning alerts were fixed: https://github.com/solarwinds/net-changesets/security/code-scanning

Checklist

  • I have double-checked my own changes
  • I have read the Contribution Guidelines
  • Include the issue number (#xxx) in the branch name, PR title, and PR description in the Issue number section above
  • Provide a reasonable description of the PR in the Changes section
  • I have commented on the issue above and discussed the intended changes
  • All newly added code is adequately covered by tests
  • Make sure your PR is passing the CI/CD pipeline
  • The documentation was modified to reflect the changes OR No documentation changes are required.

@magiino magiino self-assigned this Jan 2, 2026
@magiino magiino requested a review from a team as a code owner January 2, 2026 10:27
Copy link
Copy Markdown
Contributor

@jvilimek jvilimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magiino magiino merged commit 2cb734c into main Jan 5, 2026
4 checks passed
@magiino magiino deleted the 19-fix-publish-command branch January 5, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants