Include map images?

[sn3p]

We currently offer links to map image packs, but could include them by default as well.
This means releases will significantly increase in size.

We currently have this placeholder image, which suggests we include map images:

[ThomasVdBerge]

Not sure, having version releases to only include new map images seems a bit too much hassle.

Might be a better idea to have a script to fetch all maps/update so new map images come in automatically

[sn3p]

Not sure, having version releases to only include new map images seems a bit too much hassle.

I'm not planning to bump the version every time a new image is submitted. In fact, I prefer not to create a new release for every change we make. Users can submit their own images, just have to approve them and they will be included in the next release.

Might be a better idea to have a script to fetch all maps/update so new map images come in automatically

Interesting. I'm not sure about an update script, but we could use the repo as a CDN:
https://raw.githubusercontent.com/sn3p/utstats/7ff955bd/html/assets/images/maps/duku_large.jpg
E.g. first check if the file exists locally, if not check for a CDN file, otherwise show a fallback image.

[davidbernard04]

@sn3p I didn't know you provided links to the map images. Where is this link?

Because you do have a bunch of maps under the assets.

And on my side I was working to create new ones for the standard maps.

[sn3p]

I didn't know you provided links to the map images. Where is this link?

@davidbernard04 in the README under UTStats Web Installation you'll find these links:

• Standard pack
• Additional CTF pack
• Enakins pack

I never used them, but I think these images don't have the correct filenames and dimensions by default. So you probably have to rename/resize them.

Because you do have a bunch of maps under the assets

These always been there afaik, I never added any myself.

And on my side I was working to create new ones for the standard maps.

Awesome, please share them if you have new ones <3

[davidbernard04]

@sn3p OK I see, those are the old low-res square format which would appear all stretched-up here.

May I suggest you include in git only 900x300 images?

[sn3p]

May I suggest you include in git only 900x300 images?

If we're going to include the them will be in the correct format of course.

But the question remains, I'm not sure if we even want to include all map images. Releases could get pretty large, we would need to maintain them, overseeing the quality is good enough, etc.

[davidbernard04]

For my part I do like when everything is bundled together, easier to use.

About the size of releases, let's say a map image takes 150 KB (at least the ones I did, hehe). Having 200 hundreds map images would take 30 MB. It's not that bad, no?

[randommonk]

Already thought about this in the past but seems a good time to mention it:

We should separate out the config that is local (ftp settings, info of UT servers etc.) from the other config and add it to a .gitignore so that people's git doesn't identify changes to it (unless you git add -f it)

That way, users who want to just have their web host pulling updates (for maps for example) directly from github can do so. Git is the perfect choice for something that tracks updates and users can choose when to download them.

I can raise a separate discussion topic for it if you think it needs it?

Agreed - 30MB is nothing.

[sn3p]

About the size of releases, let's say a map image takes 150 KB (at least the ones I did, hehe). Having 200 hundreds map images would take 30 MB. It's not that bad, no?

Agreed. I have a few new map images, will add them soon!

We should separate out the config that is local (ftp settings, info of UT servers etc.) from the other config and add it to a .gitignore so that people's git doesn't identify changes to it (unless you git add -f it)

That way, users who want to just have their web host pulling updates (for maps for example) directly from github can do so. Git is the perfect choice for something that tracks updates and users can choose when to download them.

Ik like the idea of separating local and privacy sensitive settings. Let's discuss this in a new issue 👍