Non-Blocking Review Concern: Plan prescribes git add -A in violation of global rule
Source: pre-push whole-codebase review
Location: docs/plans/2026-04-19-caddy-forms-auth.md:581
Date: 2026-04-19
What was flagged
Task 7 Step 8 instructs git add -A. The user's global CLAUDE.md explicitly forbids this in favor of adding files individually. By this point in the plan all earlier tasks (1, 3, 5, 6) have already committed their own changes, so Step 8 likely has nothing new to add from tracked paths anyway — the instruction should be replaced with explicit git add <path> <path> ... or dropped. Not introduced by this diff's contract-level structure (it's a forward-looking recommendation, not broken code), so not blocking; worth fixing before the plan is executed.
Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh
Non-Blocking Review Concern: Plan prescribes
git add -Ain violation of global ruleSource: pre-push whole-codebase review
Location:
docs/plans/2026-04-19-caddy-forms-auth.md:581Date: 2026-04-19
What was flagged
Task 7 Step 8 instructs
git add -A. The user's global CLAUDE.md explicitly forbids this in favor of adding files individually. By this point in the plan all earlier tasks (1, 3, 5, 6) have already committed their own changes, so Step 8 likely has nothing new to add from tracked paths anyway — the instruction should be replaced with explicitgit add <path> <path> ...or dropped. Not introduced by this diff's contract-level structure (it's a forward-looking recommendation, not broken code), so not blocking; worth fixing before the plan is executed.Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh