Non-Blocking Review Concern: Same dot-vs-hyphen glob mismatch exists for operator-first-login log
Source: pre-push whole-codebase review
Location: config/logrotate.conf:34
Date: 2026-04-18
What was flagged
scripts/server/setup-application-preparation.sh:247,266-268 writes the log as com.${HOSTNAME_LOWER}.operator-first-login.log (dot-form label — e.g. com.tilsit.operator-first-login.log), but config/logrotate.conf:34 uses /Users/*/.local/state/com.*-operator-first-login.log (hyphen-form). This is the identical class of bug the mount-nas-media fix addresses; the operator-first-login log will silently never rotate. Fix: change the glob to com.*.operator-first-login.log and add a matching bats positive case. Pre-existing — not introduced by this diff.
Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh
Non-Blocking Review Concern: Same dot-vs-hyphen glob mismatch exists for operator-first-login log
Source: pre-push whole-codebase review
Location:
config/logrotate.conf:34Date: 2026-04-18
What was flagged
scripts/server/setup-application-preparation.sh:247,266-268writes the log ascom.${HOSTNAME_LOWER}.operator-first-login.log(dot-form label — e.g.com.tilsit.operator-first-login.log), butconfig/logrotate.conf:34uses/Users/*/.local/state/com.*-operator-first-login.log(hyphen-form). This is the identical class of bug the mount-nas-media fix addresses; the operator-first-login log will silently never rotate. Fix: change the glob tocom.*.operator-first-login.logand add a matching bats positive case. Pre-existing — not introduced by this diff.Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh