Non-Blocking Review Concern: Duplicated collect_error/collect_warning/set_section functions across modules
Source: code-reviewer (structural observation from diff)
Location: scripts/server/setup-command-line-tools.sh:25, scripts/server/setup-remote-desktop.sh:17
PR: #25 — Modularize first boot (#25)
Date: 2026-04-07
What was flagged
The collect_error, collect_warning, and set_section helper functions are copy-pasted identically into multiple module scripts rather than sourced from a shared library file. This creates a maintenance burden where a bug fix in one copy must be replicated across all modules. Consider extracting these into a shared lib/logging.sh that each module sources.
Context
This issue was automatically created from a non-blocking concern identified
during pre-merge review of PR #25. It was safe to merge but worth tracking.
Created by lib-review-issues.sh
Non-Blocking Review Concern: Duplicated collect_error/collect_warning/set_section functions across modules
Source: code-reviewer (structural observation from diff)
Location:
scripts/server/setup-command-line-tools.sh:25, scripts/server/setup-remote-desktop.sh:17PR: #25 — Modularize first boot (#25)
Date: 2026-04-07
What was flagged
The
collect_error,collect_warning, andset_sectionhelper functions are copy-pasted identically into multiple module scripts rather than sourced from a shared library file. This creates a maintenance burden where a bug fix in one copy must be replicated across all modules. Consider extracting these into a sharedlib/logging.shthat each module sources.Context
This issue was automatically created from a non-blocking concern identified
during pre-merge review of PR #25. It was safe to merge but worth tracking.
Created by lib-review-issues.sh