Non-Blocking Review Concern: cleanup_empty_dirs glob limited to 2 directory levels
Source: claude (automated reviewer)
Location: app-setup/templates/transmission-done.sh
PR: #113 — fix(transmission-filebot): replace find(1) with NFS-safe alternatives (#113)
Date: 2026-04-05
What was flagged
The new cleanup_empty_dirs() function uses glob patterns that only reach 2 levels deep (${dir}/*/*/ and ${dir}/*/), whereas the old find -type d -empty -delete handled arbitrary depth. Unlikely to matter for typical torrent layouts (flat or one subdirectory), but adding a */*/*/ pattern would cover one more level if edge cases arise.
Context
This issue was automatically created from a non-blocking concern identified
during pre-merge review of PR #113. It was safe to merge but worth tracking.
Created by lib-review-issues.sh
Non-Blocking Review Concern: cleanup_empty_dirs glob limited to 2 directory levels
Source: claude (automated reviewer)
Location:
app-setup/templates/transmission-done.shPR: #113 — fix(transmission-filebot): replace find(1) with NFS-safe alternatives (#113)
Date: 2026-04-05
What was flagged
The new
cleanup_empty_dirs()function uses glob patterns that only reach 2 levels deep (${dir}/*/*/and${dir}/*/), whereas the oldfind -type d -empty -deletehandled arbitrary depth. Unlikely to matter for typical torrent layouts (flat or one subdirectory), but adding a*/*/*/pattern would cover one more level if edge cases arise.Context
This issue was automatically created from a non-blocking concern identified
during pre-merge review of PR #113. It was safe to merge but worth tracking.
Created by lib-review-issues.sh