SK-2142 fix insert response, invoke connection and unit tests

Author: raushan-skyflow

skyflow/utils/_utils.py

@@ -238,7 +238,8 @@ def parse_insert_response(api_response, continue_on_error):
                 error = {
                     'request_index': idx,
                     'request_id': request_id,
-                    'error': response['Body']['error']
+                    'error': response['Body']['error'],
+                    'http_code': response['Status'],
                 }
                 errors.append(error)
 
@@ -352,7 +353,7 @@ def parse_invoke_connection_response(api_response: requests.Response):
             if 'x-request-id' in api_response.headers:
                 metadata['request_id'] = api_response.headers['x-request-id']
 
-            return InvokeConnectionResponse(data=data, metadata=metadata)
+            return InvokeConnectionResponse(data=data, metadata=metadata, errors=None)
         except Exception as e:
             raise SkyflowError(SkyflowMessages.Error.RESPONSE_NOT_JSON.value.format(content), status_code)
     except HTTPError:

skyflow/vault/connection/_invoke_connection_response.py

@@ -1,10 +1,11 @@
 class InvokeConnectionResponse:
-    def __init__(self, data=None, metadata=None):
+    def __init__(self, data=None, metadata=None, errors=None):
         self.data = data
         self.metadata = metadata if metadata else {}
+        self.errors = errors if errors else None
 
     def __repr__(self):
-        return f"ConnectionResponse('data'={self.data},'metadata'={self.metadata})"
+        return f"ConnectionResponse('data'={self.data},'metadata'={self.metadata}), 'errors'={self.errors})"
 
     def __str__(self):
         return self.__repr__()

tests/utils/test__utils.py

@@ -252,6 +252,12 @@ def test_parse_insert_response(self):
         result = parse_insert_response(api_response, continue_on_error=True)
         self.assertEqual(len(result.inserted_fields), 1)
         self.assertEqual(len(result.errors), 1)
+        # Assert first successful record
+        self.assertEqual(result.inserted_fields[0]["skyflow_id"], "id1")
+        # Assert error record
+        self.assertEqual(result.errors[0]["error"], TEST_ERROR_MESSAGE)
+        self.assertEqual(result.errors[0]["http_code"], 400)
+        self.assertEqual(result.errors[0]["request_id"], "12345")
 
     def test_parse_insert_response_continue_on_error_false(self):
         mock_api_response = Mock()
@@ -384,6 +390,7 @@ def test_parse_invoke_connection_response_successful(self, mock_response):
         self.assertIsInstance(result, InvokeConnectionResponse)
         self.assertEqual(result.data["key"], "value")
         self.assertEqual(result.metadata["request_id"], "1234")
+        self.assertEqual(result.errors, None)
 
     @patch("requests.Response")
     def test_parse_invoke_connection_response_json_decode_error(self, mock_response):