From ffa08f95d091d570f3d404d259f5780e01527e40 Mon Sep 17 00:00:00 2001 From: Ludwig Schwardt Date: Mon, 10 Nov 2025 15:36:43 +0200 Subject: [PATCH] SPR1-3199 Support MK+ compatible gain setting The new "float_or_default" script option type supports gain setting on both MK (via an undocumented feature) and MK+ correlators. We just treat all gains as floats instead of the purported ints in the original MK ICD. --- observation/basic_health.py | 2 +- observation/bf_phaseup.py | 2 +- observation/calibrate_delays.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/observation/basic_health.py b/observation/basic_health.py index cb910961..7bb3ca6a 100755 --- a/observation/basic_health.py +++ b/observation/basic_health.py @@ -21,7 +21,7 @@ class NoTargetsUpError(Exception): parser.add_option('--verify-duration', type='float', default=64.0, help='Length of time to revisit source for verification, ' 'in seconds (default=%default)') -parser.add_option('--fengine-gain', type='int_or_default', default='default', +parser.add_option('--fengine-gain', type='float_or_default', default='default', help='Set correlator F-engine gain (average magnitude)') # Set default value for any option (both standard and experiment-specific options) parser.set_defaults(observer='basic_health', nd_params='off', diff --git a/observation/bf_phaseup.py b/observation/bf_phaseup.py index 79505fea..a67a0b4f 100755 --- a/observation/bf_phaseup.py +++ b/observation/bf_phaseup.py @@ -101,7 +101,7 @@ def calculate_corrections(G_gains, B_gains, delays, cal_channel_freqs, parser.add_option('--verify-duration', type='float', default=64.0, help='Length of time to revisit the source for verification, ' 'in seconds (default=%default)') -parser.add_option('--fengine-gain', type='int_or_default', default='default', +parser.add_option('--fengine-gain', type='float_or_default', default='default', help='Set correlator F-engine gain (average magnitude)') parser.add_option('--fft-shift', type='int_or_default', help='Override correlator F-engine FFT shift') diff --git a/observation/calibrate_delays.py b/observation/calibrate_delays.py index c43c78b1..074fc962 100755 --- a/observation/calibrate_delays.py +++ b/observation/calibrate_delays.py @@ -27,7 +27,7 @@ class NoTargetsUpError(Exception): parser.add_option('--verify-duration', type='float', default=64.0, help='Length of time to revisit the source for verification, ' 'in seconds (default=%default)') -parser.add_option('--fengine-gain', type='int_or_default', default='default', +parser.add_option('--fengine-gain', type='float_or_default', default='default', help='Set correlator F-engine gain') parser.add_option('--fft-shift', type='int_or_default', default='default', help='Set correlator F-engine FFT shift')