Skip to content

Commit 45cbb66

Browse files
authored
chore: update webhooks tests (#136)
1 parent aed15e9 commit 45cbb66

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

tests/unit/domains/numbers/v1/webhooks/events/test_numbers_webhooks_event_model.py renamed to tests/unit/domains/numbers/v1/sinch_events/events/test_number_sinch_event_model.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def invalid_data():
3030
}
3131

3232

33-
def test_numbers_webhooks_response_expects_parsed_data(valid_data):
33+
def test_number_sinch_event_response_expects_parsed_data(valid_data):
3434
"""
3535
Expects all fields to map correctly from camelCase input
3636
and handle valid data appropriately.
@@ -51,7 +51,7 @@ def test_numbers_webhooks_response_expects_parsed_data(valid_data):
5151
assert response.extra_field == "extra_value"
5252

5353

54-
def test_numbers_webhooks_response_missing_optional_fields_expects_parsed_data():
54+
def test_number_sinch_event_response_missing_optional_fields_expects_parsed_data():
5555
"""
5656
Expects the model to handle missing optional fields.
5757
"""
@@ -71,7 +71,7 @@ def test_numbers_webhooks_response_missing_optional_fields_expects_parsed_data()
7171
assert response.failure_code is None
7272

7373

74-
def test_numbers_webhooks_response_invalid_data_expects_validation_error(invalid_data):
74+
def test_number_sinch_event_response_invalid_data_expects_validation_error(invalid_data):
7575
"""
7676
Expects the model to raise a validation error for invalid data.
7777
"""

tests/unit/domains/numbers/v1/webhooks/test_numbers_webhooks.py renamed to tests/unit/domains/numbers/v1/sinch_events/test_number_sinch_event.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def string_to_sign():
1515

1616

1717
@pytest.fixture
18-
def numbers_webhooks():
18+
def sinch_events():
1919
return SinchEvents('my-callback-secret')
2020

2121

@@ -34,11 +34,11 @@ def base_payload_parse_event():
3434
}
3535

3636

37-
def test_valid_signature_header_expects_successful_validation(numbers_webhooks, string_to_sign):
37+
def test_valid_signature_header_expects_successful_validation(sinch_events, string_to_sign):
3838
headers = {
3939
"X-Sinch-Signature": "8e58baa351ffa5e0d7eaef3c739d0d7aa6093da3"
4040
}
41-
response = numbers_webhooks.validate_authentication_header(headers, string_to_sign)
41+
response = sinch_events.validate_authentication_header(headers, string_to_sign)
4242
assert response is True
4343

4444

@@ -56,17 +56,17 @@ def test_valid_signature_header_expects_successful_validation(numbers_webhooks,
5656
)
5757
]
5858
)
59-
def test_parse_event_expects_timestamp_as_utc(numbers_webhooks, test_name, timestamp_str):
59+
def test_parse_event_expects_timestamp_as_utc(sinch_events, test_name, timestamp_str):
6060
payload = {"timestamp": timestamp_str}
61-
parsed = numbers_webhooks.parse_event(payload)
61+
parsed = sinch_events.parse_event(payload)
6262
expected = datetime(
6363
2025, 4, 6, 8, 45, 27, 565347, tzinfo=timezone.utc
6464
)
6565
assert parsed.timestamp == expected
6666

6767

68-
def test_parse_event_expects_parsed_response(numbers_webhooks, base_payload_parse_event):
69-
response = numbers_webhooks.parse_event(base_payload_parse_event)
68+
def test_parse_event_expects_parsed_response(sinch_events, base_payload_parse_event):
69+
response = sinch_events.parse_event(base_payload_parse_event)
7070
assert isinstance(response, NumberSinchEvent)
7171
assert response.event_id == "01jr7stexp0znky34pj07dwp41"
7272
assert response.project_id == "project-id"

0 commit comments

Comments
 (0)