fix import other proto bug, without changing the xxx_pb variable #22
Open
lifelongchaser wants to merge 1 commit into
Open
fix import other proto bug, without changing the xxx_pb variable #22lifelongchaser wants to merge 1 commit into
lifelongchaser wants to merge 1 commit into
Conversation
|
This soluation leads to another bug. If there are a lot of messages or enums in proto file, it will create lots of local variables . More than 200 local variables in a chunk lead to lua error. |
|
local player = player_pb.Player() this is a example,and it work success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an error occurs when you want to use other message type from another proto file,
e.g.
mail.proto:
reward.proto:
test.lua:
The same thing happens when using repeated instead of optional.
The reason is that
mail_pb.luagenerated by protoc-gen-lua doesn't consider the situation of other proto msg type. The message_type is nil.some guy has fixed this bug by putting the REWARD table to XXX_pb variable. But I offer another method without changing XXX_pb.
you can choose whether is more fit considering your program structure.
Thank you for reading.