From 4ba1ce69210e5d0ca726e098a07de3b48484b022 Mon Sep 17 00:00:00 2001 From: Neil Vaytet Date: Tue, 17 Mar 2026 08:51:43 +0100 Subject: [PATCH 1/3] do not allow nbshinx errors in docs builds for essimaging --- packages/essimaging/docs/conf.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/essimaging/docs/conf.py b/packages/essimaging/docs/conf.py index 39f82d23..e1f4babe 100644 --- a/packages/essimaging/docs/conf.py +++ b/packages/essimaging/docs/conf.py @@ -46,8 +46,6 @@ except ModuleNotFoundError: pass -nbsphinx_allow_errors = True - myst_enable_extensions = [ "amsmath", "colon_fence", From 1ba8bef8289df63a595994fc7e02ef24adce0c14 Mon Sep 17 00:00:00 2001 From: Neil Vaytet Date: Tue, 17 Mar 2026 09:11:58 +0100 Subject: [PATCH 2/3] add threshold for lut as Inf default in Odin and TBL workflows --- packages/essimaging/src/ess/odin/workflows.py | 8 ++++++++ packages/essimaging/src/ess/tbl/workflow.py | 8 ++++++++ packages/essimaging/tests/odin/data_reduction_test.py | 4 ---- packages/essimaging/tests/tbl/data_reduction_test.py | 5 ----- 4 files changed, 16 insertions(+), 9 deletions(-) diff --git a/packages/essimaging/src/ess/odin/workflows.py b/packages/essimaging/src/ess/odin/workflows.py index 8e2d804b..b596bf0d 100644 --- a/packages/essimaging/src/ess/odin/workflows.py +++ b/packages/essimaging/src/ess/odin/workflows.py @@ -14,6 +14,7 @@ BeamMonitor3, BeamMonitor4, DarkBackgroundRun, + LookupTableRelativeErrorThreshold, NeXusMonitorName, OpenBeamRun, PulseStrideOffset, @@ -29,6 +30,13 @@ def default_parameters() -> dict: NeXusMonitorName[BeamMonitor3]: "beam_monitor_3", NeXusMonitorName[BeamMonitor4]: "beam_monitor_4", PulseStrideOffset: None, + LookupTableRelativeErrorThreshold: { + "event_mode_detectors/timepix3": float('inf'), + "beam_monitor_1": float('inf'), + "beam_monitor_2": float('inf'), + "beam_monitor_3": float('inf'), + "beam_monitor_4": float('inf'), + }, } diff --git a/packages/essimaging/src/ess/tbl/workflow.py b/packages/essimaging/src/ess/tbl/workflow.py index 7046a2b4..656b462f 100644 --- a/packages/essimaging/src/ess/tbl/workflow.py +++ b/packages/essimaging/src/ess/tbl/workflow.py @@ -10,6 +10,7 @@ from ..imaging.conversion import providers as conversion_providers from ..imaging.types import ( BeamMonitor1, + LookupTableRelativeErrorThreshold, NeXusMonitorName, PulseStrideOffset, SampleRun, @@ -20,6 +21,13 @@ def default_parameters() -> dict: return { NeXusMonitorName[BeamMonitor1]: "monitor_1", PulseStrideOffset: None, + LookupTableRelativeErrorThreshold: { + "timepix3_detector": float('inf'), + "ngem_detector": float('inf'), + "he3_detector_bank0": float('inf'), + "he3_detector_bank1": float('inf'), + "monitor_1": float('inf'), + }, } diff --git a/packages/essimaging/tests/odin/data_reduction_test.py b/packages/essimaging/tests/odin/data_reduction_test.py index 67edc528..2b22d02b 100644 --- a/packages/essimaging/tests/odin/data_reduction_test.py +++ b/packages/essimaging/tests/odin/data_reduction_test.py @@ -3,7 +3,6 @@ import pytest import sciline as sl -from ess.reduce.time_of_flight import LookupTableRelativeErrorThreshold import ess.odin.data # noqa: F401 from ess import odin @@ -30,9 +29,6 @@ def workflow() -> sl.Pipeline: wf[Filename[OpenBeamRun]] = odin.data.iron_simulation_ob_small() wf[NeXusDetectorName] = "event_mode_detectors/timepix3" wf[TimeOfFlightLookupTableFilename] = odin.data.odin_tof_lookup_table() - wf[LookupTableRelativeErrorThreshold] = { - "event_mode_detectors/timepix3": float('inf') - } # Cache the lookup table wf[TimeOfFlightLookupTable] = wf.compute(TimeOfFlightLookupTable) return wf diff --git a/packages/essimaging/tests/tbl/data_reduction_test.py b/packages/essimaging/tests/tbl/data_reduction_test.py index 7e8dcd3c..b1d449d0 100644 --- a/packages/essimaging/tests/tbl/data_reduction_test.py +++ b/packages/essimaging/tests/tbl/data_reduction_test.py @@ -48,11 +48,6 @@ def workflow() -> sl.Pipeline: wf = tbl.TblWorkflow() wf[Filename[SampleRun]] = tbl.data.tutorial_sample_data() wf[TimeOfFlightLookupTableFilename] = tbl.data.tbl_tof_lookup_table_no_choppers() - wf[time_of_flight.LookupTableRelativeErrorThreshold] = { - "ngem_detector": float('inf'), - "he3_detector_bank0": float('inf'), - "he3_detector_bank1": float('inf'), - } return wf From ab6c4d7e1ff6f3643f445048464a0fc4b7cd06a4 Mon Sep 17 00:00:00 2001 From: Neil Vaytet Date: Tue, 17 Mar 2026 09:18:48 +0100 Subject: [PATCH 3/3] add missing import for threshold type --- packages/essimaging/src/ess/imaging/types.py | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/essimaging/src/ess/imaging/types.py b/packages/essimaging/src/ess/imaging/types.py index 7667f920..c1620c2d 100644 --- a/packages/essimaging/src/ess/imaging/types.py +++ b/packages/essimaging/src/ess/imaging/types.py @@ -26,6 +26,7 @@ PulseStrideOffset = tof_t.PulseStrideOffset TimeOfFlightLookupTable = tof_t.TimeOfFlightLookupTable TimeOfFlightLookupTableFilename = tof_t.TimeOfFlightLookupTableFilename +LookupTableRelativeErrorThreshold = tof_t.LookupTableRelativeErrorThreshold UncertaintyBroadcastMode = _UncertaintyBroadcastMode