don't hide share replicas with replica_state null for admins#293
Open
Carthaca wants to merge 1 commit into
Open
don't hide share replicas with replica_state null for admins#293Carthaca wants to merge 1 commit into
Carthaca wants to merge 1 commit into
Conversation
Carthaca
requested review from
chuan137,
crenduchinta88,
kpawar-sap and
sumitarora2786
as code owners
kpawar-sap
previously approved these changes
Feb 4, 2026
E.g. in case of broken migrations, we can clean up the left-overs via API instead of deleting the record in the db. However, only show NULL replica_state for shares that actually support replication (replication_type IS NOT NULL). This prevents incorrectly including non-replicated share instances in replica queries. Change-Id: I94d3916917edb2946cdbc0f6de25e466d74ed56e
Carthaca
force-pushed
the
replica_state_null
branch
from
8ee59ac to
60bdce1
Compare
kpawar-sap
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. in case of broken migrations, we can clean up the left-overs
via API instead of deleting the record in the db.
Change-Id: I94d3916917edb2946cdbc0f6de25e466d74ed56e