Add latest time zero-order-hold sync policy (backport #73)#89
Merged
Conversation
* adding latest time zoh policy Signed-off-by: Michael Anderson <anderson@mbari.org> * remove commented code * Update include/message_filters/sync_policies/latest_time.h Co-authored-by: Chris Lalancette <clalancette@gmail.com> * updates from PR comments Signed-off-by: Michael Anderson <anderson@mbari.org> * cleanup includes Signed-off-by: Michael Anderson <anderson@mbari.org> * adding documentation Signed-off-by: Michael Anderson <anderson@mbari.org> * Update include/message_filters/sync_policies/latest_time.h Co-authored-by: Louise Poubel <louise@openrobotics.org> * address PR comments; add new test for if pivot changes rate and new one is selected Signed-off-by: Michael Anderson <anderson@mbari.org> * adding message rate step change detection and EMA filter reset Signed-off-by: Michael Anderson <anderson@mbari.org> * whitespace Signed-off-by: Michael Anderson <anderson@mbari.org> * whitespace Signed-off-by: Michael Anderson <anderson@mbari.org> * detect if pivot message is late Signed-off-by: Michael Anderson <anderson@mbari.org> * add ChangeRateLeading test Signed-off-by: Michael Anderson <anderson@mbari.org> * whitespace Signed-off-by: Michael Anderson <anderson@mbari.org> * Update include/message_filters/sync_policies/latest_time.h Co-authored-by: Chris Lalancette <clalancette@gmail.com> * add option to take instance of rclcpp::Clock; make magic numbers configs; other PR comments Signed-off-by: Michael Anderson <anderson@mbari.org> * clean up; handle zero period Signed-off-by: Michael Anderson <anderson@mbari.org> * check for late message after avg error is calculated Signed-off-by: Michael Anderson <anderson@mbari.org> * control test timing with sim time Signed-off-by: Michael Anderson <anderson@mbari.org> * fix msbuild compiler warnings Signed-off-by: Michael Anderson <anderson@mbari.org> Signed-off-by: Michael Anderson <anderson@mbari.org> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> (cherry picked from commit e0055f3)
|
CI:
|
quarkytale
approved these changes
Mar 10, 2023
|
Needs release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #73 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com