style(intellij): some code formatting and cleanup

Author: d-biehl

intellij-client/build.gradle.kts

@@ -27,7 +27,7 @@ kotlin {
 // Configure project's dependencies
 repositories {
     mavenCentral()
-
+    
     // IntelliJ Platform Gradle Plugin Repositories Extension - read more: https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-repositories-extension.html
     intellijPlatform {
         defaultRepositories()
@@ -37,22 +37,22 @@ repositories {
 // Dependencies are managed with Gradle version catalog - read more: https://docs.gradle.org/current/userguide/platforms.html#sub:version-catalog
 dependencies {
     compileOnly(libs.kotlinxSerialization)
-
+    
     testImplementation(kotlin("test"))
     testImplementation(libs.junit)
-
+    
     // IntelliJ Platform Gradle Plugin Dependencies Extension - read more: https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-dependencies-extension.html
     intellijPlatform {
         create(
             providers.gradleProperty("platformType"),
             providers.gradleProperty("platformVersion"),
             useInstaller = false,
         )
-
+        
         // Plugin Dependencies. Uses `platformBundledPlugins` property from the gradle.properties file for bundled IntelliJ Platform plugins.
         bundledPlugins(providers.gradleProperty("platformBundledPlugins").map { it.split(',') })
         plugins(providers.gradleProperty("platformPlugins").map { it.split(',') })
-
+        
         pluginVerifier()
         zipSigner()
         testFramework(TestFrameworkType.Platform)
@@ -64,22 +64,22 @@ intellijPlatform {
     pluginConfiguration {
         name = providers.gradleProperty("pluginName")
         version = providers.gradleProperty("pluginVersion")
-
+        
         // Extract the <!-- Plugin description --> section from README.md and provide for the plugin's manifest
         description = providers.fileContents(layout.projectDirectory.file("README.md")).asText.map {
             val start = "<!-- Plugin description -->"
             val end = "<!-- Plugin description end -->"
-
+            
             with(it.lines()) {
                 if (!containsAll(listOf(start, end))) {
                     throw GradleException("Plugin description section not found in README.md:\n$start ... $end")
                 }
                 subList(indexOf(start) + 1, indexOf(end)).joinToString("\n").let(::markdownToHTML)
             }
         }
-
+        
         val changelog = project.changelog
-
+        
         // local variable for configuration cache compatibility // Get the latest available change notes from the changelog file
         changeNotes = providers.gradleProperty("pluginVersion").map { pluginVersion ->
             with(changelog) {
@@ -89,34 +89,34 @@ intellijPlatform {
                 )
             }
         }
-
+        
         ideaVersion {
             sinceBuild = providers.gradleProperty("pluginSinceBuild")
             untilBuild = providers.gradleProperty("pluginUntilBuild")
         }
     }
-
+    
     signing {
         certificateChain = providers.environmentVariable("CERTIFICATE_CHAIN")
         privateKey = providers.environmentVariable("PRIVATE_KEY")
         password = providers.environmentVariable("PRIVATE_KEY_PASSWORD")
     }
-
+    
     publishing {
         token = providers.environmentVariable("PUBLISH_TOKEN")
-
+        
         // The pluginVersion is based on the SemVer (https://semver.org) and supports pre-release labels, like 2.1.7-alpha.3
         // Specify pre-release label to publish the plugin in a custom Release Channel automatically. Read more:
         // https://plugins.jetbrains.com/docs/intellij/deployment.html#specifying-a-release-channel
         channels = providers.gradleProperty("pluginVersion")
             .map { listOf(it.substringAfter('-', "").substringBefore('.').ifEmpty { "default" }) }
     }
-
+    
     pluginVerification {
         ides {
             recommended()
         }
-
+        
     }
 }
 
@@ -149,22 +149,22 @@ val prepareSandboxConfig: PrepareSandboxTask.() -> Unit = {
 
 tasks {
     runIde {
-
+        
         // From https://app.slack.com/client/T5P9YATH9/C5U8BM1MK
         // systemProperty("ide.experimental.ui", "true")
         // systemProperty("projectView.hide.dot.idea", "false")
         // systemProperty("terminal.new.ui", "false")
         // systemProperty("ide.tree.painter.compact.default", "true")
     }
-
+    
     wrapper {
         gradleVersion = providers.gradleProperty("gradleVersion").get()
     }
-
+    
     publishPlugin {
         dependsOn(patchChangelog)
     }
-
+    
     prepareSandbox(prepareSandboxConfig)
 }
 
@@ -190,29 +190,29 @@ tasks.withType<KotlinCompile> {
             )
         }
     }
-
+    
     prepareSandboxTask(prepareSandboxConfig)
-
+    
     plugins {
         robotServerPlugin(Constraints.LATEST_VERSION)
     }
 }
 
 @Suppress("unused") val runIdePyCharmProf by intellijPlatformTesting.runIde.registering {
     type = IntelliJPlatformType.PyCharmProfessional
-
+    
     prepareSandboxTask(prepareSandboxConfig)
 }
 
 @Suppress("unused") val runIdePyCharmCommunityEAP by intellijPlatformTesting.runIde.registering {
     type = IntelliJPlatformType.PyCharmCommunity
     version = "LATEST-EAP-SNAPSHOT"
-
+    
     prepareSandboxTask(prepareSandboxConfig)
 }
 
 @Suppress("unused") val runIdeIntellijIdeaC by intellijPlatformTesting.runIde.registering {
     type = IntelliJPlatformType.IntellijIdeaCommunity
-
+    
     prepareSandboxTask(prepareSandboxConfig)
 }

intellij-client/src/main/kotlin/dev/robotcode/robotcode4ij/RobotCodeHelpers.kt

@@ -22,7 +22,7 @@ class RobotCodeHelpers {
         val toolPath: Path = bundledPath.resolve("tool")
         val robotCodePath: Path = toolPath.resolve("robotcode")
         val checkRobotVersion: Path = toolPath.resolve("utils").resolve("check_robot_version.py")
-
+        
         val PYTHON_AND_ROBOT_OK_KEY = Key.create<Boolean?>("ROBOTCODE_PYTHON_AND_ROBOT_OK")
     }
 }
@@ -38,28 +38,28 @@ fun Project.checkPythonAndRobotVersion(reset: Boolean = false): Boolean {
     if (!reset && this.getUserData(RobotCodeHelpers.PYTHON_AND_ROBOT_OK_KEY) == true) {
         return true
     }
-
+    
     val result = ApplicationManager.getApplication().executeOnPooledThread<Boolean> {
-
+        
         val pythonInterpreter = this.robotPythonSdk?.homePath
-
+        
         if (pythonInterpreter == null) {
             thisLogger().info("No Python Interpreter defined for project '${this.name}'")
             return@executeOnPooledThread false
         }
-
+        
         if (!Path(pythonInterpreter).exists()) {
             thisLogger().warn("Python Interpreter $pythonInterpreter not exists")
             return@executeOnPooledThread false
         }
-
+        
         if (!Path(pythonInterpreter).isRegularFile()) {
             thisLogger().warn("Python Interpreter $pythonInterpreter is not a regular file")
             return@executeOnPooledThread false
         }
-
+        
         thisLogger().info("Use Python Interpreter $pythonInterpreter for project '${this.name}'")
-
+        
         val res = ExecUtil.execAndGetOutput(
             GeneralCommandLine(
                 pythonInterpreter, "-u", "-c", "import sys; print(sys.version_info[:2]>=(3,8))"
@@ -69,7 +69,7 @@ fun Project.checkPythonAndRobotVersion(reset: Boolean = false): Boolean {
             thisLogger().warn("Invalid python version")
             return@executeOnPooledThread false
         }
-
+        
         val res1 = ExecUtil.execAndGetOutput(
             GeneralCommandLine(pythonInterpreter, "-u", RobotCodeHelpers.checkRobotVersion.pathString),
             timeoutInMilliseconds = 5000
@@ -78,13 +78,13 @@ fun Project.checkPythonAndRobotVersion(reset: Boolean = false): Boolean {
             thisLogger().warn("Invalid Robot Framework version")
             return@executeOnPooledThread false
         }
-
+        
         return@executeOnPooledThread true
-
+        
     }.get()
-
+    
     this.putUserData(RobotCodeHelpers.PYTHON_AND_ROBOT_OK_KEY, result)
-
+    
     return result
 }
 
@@ -100,7 +100,7 @@ fun Project.buildRobotCodeCommandLine(
     if (!this.checkPythonAndRobotVersion()) {
         throw IllegalArgumentException("PythonSDK is not defined or robot version is not valid for project ${this.name}")
     }
-
+    
     val pythonInterpreter = this.robotPythonSdk?.homePath
     val commandLine = GeneralCommandLine(
         pythonInterpreter,
@@ -115,6 +115,6 @@ fun Project.buildRobotCodeCommandLine(
         *extraArgs,
         *args
     ).withWorkDirectory(this.basePath).withCharset(Charsets.UTF_8)
-
+    
     return commandLine
 }

intellij-client/src/main/kotlin/dev/robotcode/robotcode4ij/TextMateBundleHolder.kt

@@ -8,26 +8,26 @@ import org.jetbrains.plugins.textmate.language.syntax.TextMateSyntaxTableBuilder
 
 object TextMateBundleHolder {
     private val interner = TextMateConcurrentMapInterner()
-
+    
     val descriptor: TextMateLanguageDescriptor by lazy {
-
+        
         val reader = TextMateService.getInstance().readBundle(RobotCodeHelpers.basePath)
             ?: throw IllegalStateException("Failed to read robotcode textmate bundle")
-
+        
         val builder = TextMateSyntaxTableBuilder(interner)
-
+        
         val grammarIterator = reader.readGrammars().iterator()
         while (grammarIterator.hasNext()) {
             val grammar = grammarIterator.next()
-
-            val rootScopeName =  builder.addSyntax(grammar.plist.value) ?: continue
+            
+            val rootScopeName = builder.addSyntax(grammar.plist.value) ?: continue
             if (rootScopeName == "source.robotframework") {
                 val syntax = builder.build()
                 return@lazy TextMateLanguageDescriptor(rootScopeName, syntax.getSyntax(rootScopeName))
             }
         }
-
+        
         throw IllegalStateException("Failed to find robotcode textmate in bundle")
     }
-
+    
 }

intellij-client/src/main/kotlin/dev/robotcode/robotcode4ij/configuration/RobotCodeColorSettingsPage.kt

@@ -11,7 +11,7 @@ import dev.robotcode.robotcode4ij.highlighting.RobotCodeSyntaxHighlighter
 import javax.swing.Icon
 
 class RobotCodeColorSettingsPage : ColorSettingsPage {
-
+    
     private val descriptors: Array<AttributesDescriptor> = arrayOf(
         AttributesDescriptor("Header", Colors.HEADER),
         AttributesDescriptor("Test case name", Colors.TESTCASE_NAME),
@@ -30,37 +30,37 @@ class RobotCodeColorSettingsPage : ColorSettingsPage {
         AttributesDescriptor("Variable expression", Colors.VARIABLE_EXPRESSION),
         AttributesDescriptor("Variable begin", Colors.VARIABLE_BEGIN),
         AttributesDescriptor("Variable end", Colors.VARIABLE_END),
-
+        
         AttributesDescriptor("Line comment", Colors.LINE_COMMENT),
         AttributesDescriptor("Block comment", Colors.BLOCK_COMMENT),
-
+        
         AttributesDescriptor("Operator", Colors.OPERATOR),
         AttributesDescriptor("Namespace", Colors.NAMESPACE),
         AttributesDescriptor("BDD prefix", Colors.BDD_PREFIX),
-
+        
         AttributesDescriptor("Continuation", Colors.CONTINUATION),
     )
-
+    
     override fun getAttributeDescriptors(): Array<AttributesDescriptor> {
         return descriptors
     }
-
+    
     override fun getColorDescriptors(): Array<ColorDescriptor> {
         return ColorDescriptor.EMPTY_ARRAY
     }
-
+    
     override fun getDisplayName(): String {
         return "Robot Framework"
     }
-
+    
     override fun getIcon(): Icon? {
         return RobotIcons.RobotCode
     }
-
+    
     override fun getHighlighter(): SyntaxHighlighter {
         return RobotCodeSyntaxHighlighter()
     }
-
+    
     override fun getDemoText(): String {
         return """
         *** Settings ***
@@ -124,7 +124,7 @@ class RobotCodeColorSettingsPage : ColorSettingsPage {
         with multiple lines
         """.trimIndent()
     }
-
+    
     override fun getAdditionalHighlightingTagToDescriptorMap(): MutableMap<String, TextAttributesKey>? {
         return null
     }