From cacbe8a2cfa91d1a42eef24f51638df5a685a546 Mon Sep 17 00:00:00 2001 From: Aditya Nair Date: Tue, 21 Apr 2026 13:17:48 +0530 Subject: [PATCH] sbchooser: fix load_secdb_from_file returning fd instead of rc When read_file() fails, returning fd instead of rc causes callers to miss the error since fd is a non-negative integer after close(). Fix by returning rc. Signed-off-by: Aditya Nair --- src/sbchooser-db.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sbchooser-db.c b/src/sbchooser-db.c index e49ce533..e121a456 100644 --- a/src/sbchooser-db.c +++ b/src/sbchooser-db.c @@ -256,7 +256,7 @@ load_secdb_from_file(const char * const filename, efi_secdb_t **secdbp) close(fd); if (rc < 0) { efi_error("Could not read file \"%s\": %m", filename); - return fd; + return rc; } data_size -= 1;