fix: PR comments

Author: Swiftwork

packages/browser-sdk/src/client.ts

@@ -924,8 +924,8 @@ export class ReflagClient {
         });
       },
       isEnabledOverride: this.flagsClient.getFlagOverride(flagKey),
-      async setIsEnabledOverride(isEnabled: boolean | null) {
-        await self.flagsClient.setFlagOverride(flagKey, isEnabled);
+      setIsEnabledOverride(isEnabled: boolean | null) {
+        self.flagsClient.setFlagOverride(flagKey, isEnabled);
       },
     };
   }

packages/browser-sdk/test/client.test.ts

@@ -70,7 +70,7 @@ describe("ReflagClient", () => {
       await client.initialize();
       expect(flagsResult["flagA"].isEnabled).toBe(true);
       expect(client.getFlag("flagA").isEnabled).toBe(true);
-      void client.getFlag("flagA").setIsEnabledOverride(false);
+      client.getFlag("flagA").setIsEnabledOverride(false);
       expect(client.getFlag("flagA").isEnabled).toBe(false);
     });
   });

packages/browser-sdk/test/flags.test.ts

@@ -350,7 +350,7 @@ describe("FlagsClient", () => {
 
     expect(updated).toBe(false);
 
-    void client.setFlagOverride("flagA", false);
+    client.setFlagOverride("flagA", false);
 
     expect(updated).toBe(true);
     expect(client.getFlags().flagA.isEnabled).toBe(true);
@@ -375,7 +375,7 @@ describe("FlagsClient", () => {
 
     // Setting an override for a flag that doesn't exist in fetched flags
     // should not trigger an update since the merged flags don't change
-    void client.setFlagOverride("flagC", true);
+    client.setFlagOverride("flagC", true);
 
     expect(updated).toBe(false);
     expect(client.getFlags().flagC).toBeUndefined();

packages/node-sdk/src/client.ts

@@ -699,12 +699,12 @@ export class ReflagClient {
    **/
   public getFlagsForBootstrap({
     enableTracking = true,
-    meta,
     ...context
   }: ContextWithTracking): BootstrappedFlags {
+    const contextWithTracking = { enableTracking, ...context };
     return {
-      context,
-      flags: this._getFlags({ enableTracking, meta, ...context }),
+      context: contextWithTracking,
+      flags: this._getFlags(contextWithTracking),
     };
   }
 

packages/react-sdk/README.md

@@ -510,26 +510,7 @@ The `<ReflagProvider>` initializes the Reflag SDK, fetches flags and starts list
 - `expireTimeMs`: If set, flags will be cached between page loads for this duration (in milliseconds).
 - `staleTimeMs`: Maximum time (in milliseconds) that stale flags will be returned if `staleWhileRevalidate` is true and new flags cannot be fetched.
 - `offline`: Provide this option when testing or in local development environments to avoid contacting Reflag servers.
-- `loadingComponent` lets you specify an React component to be rendered instead of the children while the Reflag provider is initializing. If you want more control over loading screens, `useFlag()` returns `isLoading` which you can use to customize the loading experience:
-
-  ```tsx
-  function LoadingReflag({ children }) {
-    const { isLoading } = useFlag("myFlag");
-    if (isLoading) {
-      return <Spinner />;
-    }
-
-    return children;
-  }
-
-  //-- Initialize the Reflag provider
-  <ReflagProvider publishableKey={YOUR_PUBLISHABLE_KEY} /*...*/>
-    <LoadingReflag>
-      {/* children here are shown when loading finishes */}
-    </LoadingReflag>
-  </ReflagProvider>;
-  ```
-
+- `loadingComponent` lets you specify an React component to be rendered instead of the children while the Reflag provider is initializing. If you want more control over loading screens, `useFlag()` and `useIsLoading` returns `isLoading` which you can use to customize the loading experience.
 - `enableTracking`: Set to `false` to stop sending tracking events and user/company updates to Reflag. Useful when you're impersonating a user (defaults to `true`),
 - `apiBaseUrl`: Optional base URL for the Reflag API. Use this to override the default API endpoint,
 - `appBaseUrl`: Optional base URL for the Reflag application. Use this to override the default app URL,
@@ -584,6 +565,7 @@ Returns the state of a given flag for the current context. The hook provides typ
 
 ```tsx
 import { useFlag } from "@reflag/react-sdk";
+import { Loading } from "./Loading";
 
 function StartHuddleButton() {
   const {
@@ -772,6 +754,25 @@ function LoggingWrapper({ children }: { children: ReactNode }) {
 }
 ```
 
+### `useIsLoading()`
+
+Returns the loading state of the flags in the `ReflagClient`.
+
+```tsx
+import { useIsLoading } from "@reflag/react-sdk";
+import { Spinner } from "./Spinner";
+
+function LoadingWrapper({ children }: { children: ReactNode }) {
+  const isLoading = useIsLoading();
+
+  if (isLoading) {
+    return <Spinner />;
+  }
+
+  return children;
+}
+```
+
 ## Migrating from Bucket SDK
 
 If you have been using the Bucket SDKs, the following list will help you migrate to Reflag SDK: