fix(node-sdk): avoid sending "check"'s when using getFeatures

Author: roncohen

packages/node-sdk/src/client.ts

@@ -666,14 +666,17 @@ export class BucketClient {
     const features = this._getFeatures(options);
     const feature = features[key];
 
-    return this._wrapRawFeature(options, {
-      key,
-      isEnabled: feature?.isEnabled ?? false,
-      targetingVersion: feature?.targetingVersion,
-      config: feature?.config,
-      ruleEvaluationResults: feature?.ruleEvaluationResults,
-      missingContextFields: feature?.missingContextFields,
-    });
+    return this._wrapRawFeature(
+      { ...options, enableChecks: true },
+      {
+        key,
+        isEnabled: feature?.isEnabled ?? false,
+        targetingVersion: feature?.targetingVersion,
+        config: feature?.config,
+        ruleEvaluationResults: feature?.ruleEvaluationResults,
+        missingContextFields: feature?.missingContextFields,
+      },
+    );
   }
 
   /**
@@ -1199,7 +1202,11 @@ export class BucketClient {
   }
 
   private _wrapRawFeature<TKey extends keyof TypedFeatures>(
-    { enableTracking, ...context }: { enableTracking: boolean } & Context,
+    {
+      enableTracking,
+      enableChecks = false,
+      ...context
+    }: { enableTracking: boolean; enableChecks?: boolean } & Context,
     { config, ...feature }: RawFeature,
   ): TypedFeatures[TKey] {
     // eslint-disable-next-line @typescript-eslint/no-this-alias
@@ -1211,7 +1218,7 @@ export class BucketClient {
 
     return {
       get isEnabled() {
-        if (enableTracking) {
+        if (enableTracking && enableChecks) {
           void client
             .sendFeatureEvent({
               action: "check",
@@ -1232,7 +1239,7 @@ export class BucketClient {
         return feature.isEnabled;
       },
       get config() {
-        if (enableTracking) {
+        if (enableTracking && enableChecks) {
           void client
             .sendFeatureEvent({
               action: "check-config",

packages/node-sdk/test/client.test.ts

@@ -1646,7 +1646,7 @@ describe("BucketClient", () => {
       expect(events).toStrictEqual([]);
     });
 
-    it("`isEnabled` sends `check` event", async () => {
+    it("`isEnabled` does not send `check` event", async () => {
       const context = {
         company,
         user,
@@ -1665,21 +1665,10 @@ describe("BucketClient", () => {
         .flatMap((call) => call[2])
         .filter((e) => e.action === "check");
 
-      expect(checkEvents).toStrictEqual([
-        {
-          type: "feature-flag-event",
-          action: "check",
-          key: "feature1",
-          targetingVersion: 1,
-          evalResult: true,
-          evalContext: context,
-          evalRuleResults: [true],
-          evalMissingFields: [],
-        },
-      ]);
+      expect(checkEvents).toStrictEqual([]);
     });
 
-    it("`config` sends `check` event", async () => {
+    it("`config` does not send `check` event", async () => {
       const context = {
         company,
         user,
@@ -1690,7 +1679,7 @@ describe("BucketClient", () => {
       await client.initialize();
       const feature = client.getFeatures(context);
 
-      // trigger `check` event
+      // attempt to trigger `check` event
       expect(feature.feature1.config).toBeDefined();
 
       await client.flush();
@@ -1699,23 +1688,7 @@ describe("BucketClient", () => {
         .flatMap((call) => call[2])
         .filter((e) => e.action === "check-config");
 
-      expect(checkEvents).toStrictEqual([
-        {
-          type: "feature-flag-event",
-          action: "check-config",
-          key: "feature1",
-          evalResult: {
-            key: "config-1",
-            payload: {
-              something: "else",
-            },
-          },
-          targetingVersion: 1,
-          evalContext: context,
-          evalRuleResults: [true],
-          evalMissingFields: [],
-        },
-      ]);
+      expect(checkEvents).toStrictEqual([]);
     });
 
     it("sends company/user events", async () => {