Skip to content

Autocrafting larger recipes - serious performance issues #1271

@dkambersky

Description

@dkambersky

Describe the bug

Hi, first let me say I've read through #980 (comment) and I understand the logic. However that thread is locked atm, so creating a new one.

It's nice that RS's autocrafting is now exhaustive, but the performance penalty is often a significant usability hit. For context, I'm relatively early-midgame in ATM10, and looking to craft a 4096k storage part, a pretty reasonably-sized part all things considered. Server isn't underpowered, relatively modern i7 chip, not much else going on. The search times out.

There are parts up to 1048m (a couple tiers up). RS won't allow me to craft even .5% of that capacity at once.
(not to mention even just the hiccups of half a second to multiple seconds while calculating simpler recipes also make it feel kinda sluggish)

The new exhaustive search is cool for the reasons described in the original thread but severly limit usability in anything but early-game scenarios. Especially if any serious expert modpacks come out that require large microcrafting recipes, products created from items from half a dozen mods, etc, the current search logic will make RS unusable for these.

I've been using RS over AE2 for years and don't want to switch, but currently I'll likely have to as I can't really scale RS to the capacities I want - despite really not building anything large at the moment.

I wish there was a way to toggle the exhaustive search off for specific crafts, and use the old algo that's significantly faster. Alternatively, maybe there's something that could be done with dynamic programming / memoization etc but I'm just guessing here, didn't read the code for the solver.

How can we reproduce this bug or crash?

  1. Set up a crafter with patterns required for a 4096k storage part
  2. Attempt to queue up a craft of a single 4096k storage part
  3. Observe

What Minecraft version is this happening on?

Minecraft 1.21.1

What NeoForge or Fabric version is this happening on?

21.1.222

What Refined Storage version is this happening on?

2.0.1

What modpack and modpack version, if any, are you using?

ATM10 6.4

Relevant log output

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions