fix: add update confirmation

Author: wtrocki

cmd/rhoas/main.go

@@ -179,7 +179,7 @@ func executeCommandWithTelemetry(rootCmd *cobra.Command, cmdFactory *factory.Fac
 		if cmd.Runnable() && !cmd.Hidden {
 			commandPath = cmd.CommandPath()
 		}
-		_, err1 := cmdutil.DoSelfUpdateOnceADay(cmdFactory.Logger, cmdFactory.Config)
+		_, err1 := cmdutil.DoSelfUpdateOnceADay(cmdFactory)
 		if err1 != nil {
 			cmdFactory.Logger.Errorf(cmdFactory.Localizer.MustLocalize("main.update.error", localize.NewEntry("Error", err)))
 		}

pkg/core/cmdutil/selfupdate.go

@@ -3,54 +3,81 @@ package cmdutil
 import (
 	"time"
 
+	"github.com/AlecAivazis/survey/v2"
 	"github.com/blang/semver"
 	"github.com/redhat-developer/app-services-cli/internal/build"
-	"github.com/redhat-developer/app-services-cli/pkg/core/config"
-	"github.com/redhat-developer/app-services-cli/pkg/core/logging"
+	"github.com/redhat-developer/app-services-cli/pkg/core/localize"
+	"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
 	"github.com/rhysd/go-github-selfupdate/selfupdate"
 )
 
-func DoSelfUpdate(logger logging.Logger) (bool, error) {
+// DoSelfUpdate checks for updates and prompts the user to update if there is a newer version available
+func DoSelfUpdate(f *factory.Factory) (bool, error) {
 	version := build.Version
+	// TODO temp
 	if build.IsDevBuild() {
-		// TODO uncomment later
-		//return false, nil
 		version = "0.0.0"
 	}
 
 	v := semver.MustParse(version)
-	latest, err := selfupdate.UpdateSelf(v, build.RepositoryOwner+"/"+build.RepositoryName)
+	versionToUpdate, found, err := selfupdate.DefaultUpdater().DetectLatest(version)
+
+	if found && versionToUpdate.Version.Equals(v) {
+		// latest version is the same as current version. It means current binary is up to date.
+		f.Logger.Debug("Current binary is the latest version", version)
+		return false, nil
+	}
+
+	promptConfirmName := &survey.Confirm{
+		Message: f.Localizer.MustLocalize("common.selfupdate.confirm"),
+	}
+
+	var confirmUpdate bool
+	err = survey.AskOne(promptConfirmName, &confirmUpdate)
 	if err != nil {
 		return false, err
 	}
-	if latest.Version.Equals(v) {
-		// latest version is the same as current version. It means current binary is up to date.
-		logger.Debug("Current binary is the latest version", version)
-	} else {
-		logger.Info("Successfully updated RHOAS CLI to latest version", latest.Version)
-		logger.Info("Release notes:\n", latest.ReleaseNotes)
-		return true, err
+
+	if !confirmUpdate {
+		return false, nil
 	}
 
-	return false, nil
+	latest, err := selfupdate.UpdateSelf(v, build.RepositoryOwner+"/"+build.RepositoryName)
+	if err != nil {
+		return false, err
+	}
+
+	f.Logger.Info(f.Localizer.MustLocalize("common.selfupdate.success", localize.NewEntry("Version", latest.Version)))
+	return true, err
+
 }
 
-func DoSelfUpdateOnceADay(logger logging.Logger, loader config.IConfig) (bool, error) {
-	cfg, err := loader.Load()
+func DoSelfUpdateOnceADay(f *factory.Factory) (bool, error) {
+	if !f.IOStreams.CanPrompt() {
+		// Do not prompt if we are not in interactive mode
+		return false, nil
+	}
+
+	if build.IsDevBuild() {
+		return false, nil
+	}
+
+	cfg, err := f.Config.Load()
+
+	logger := f.Logger
+
 	if err != nil {
 		return false, err
 	}
-	logger.Debug("Last updated cli", cfg.LastUpdated)
+	logger.Debug("Checking for updates. Last check was done:", cfg.LastUpdated)
 
 	if cfg.LastUpdated < time.Now().AddDate(0, 0, -1).UnixMilli() {
-		logger.Debug("Updating CLI")
-
-		updated, err := DoSelfUpdate(logger)
+		updated, err := DoSelfUpdate(f)
 		if err != nil {
 			return false, err
 		}
 		cfg.LastUpdated = time.Now().UnixMilli()
-		err = loader.Save(cfg)
+		err = f.Config.Save(cfg)
 		if err != nil {
 			return false, err
 		}

pkg/core/localize/locales/en/common.en.toml

@@ -21,3 +21,14 @@ You can also disable telemetry by setting the "RHOAS_TELEMETRY" environment vari
 
 [common.telemetry.question]
 one = 'Do you agree to send anonymous data'
+
+[common.selfupdate.confirm]
+one = '''
+New version of the RHOAS CLI detected. 
+Do you want CLI to be updated to the latest version now?  
+
+NOTE: You might need to run the CLI as root to make sure that binary file can be updated.
+'''
+
+[common.selfupdate.success]
+one = 'RHOAS CLI updated to version {{.Version}}'