ImmutableModel should restrict itself to model fields.

[xlotlu]

Currently it applies the setattr / can_change_field logic to any object attribute, which trips monkey patching.

[timdiggins]

agree @xlotlu -- maybe need a way to determine whether to apply the logic or not -- however this _meta api changes in 1.8 (deprectation)/1.9(removal) so couldn't have one that supported both <=1.7 and >=1.9

see https://docs.djangoproject.com/en/1.9/ref/models/meta/

in 1.8+ we'd want to use the ._meta.get_fields() method to retrieve which are the field names I think.

So the question comes: do we want to keep supporting 1.7- ?

[xlotlu]

So the question comes: do we want to keep supporting 1.7- ?

I don't know, it's your project... :)
But it shouldn't be too hard, I doubt there's any need to do something more complicated than say

_m = model._meta
try:
    fields = _m.get_fields()
except AttributeError:
    fields = _m.fields + _m.many_to_many
    # it will take a bit of research to see if there's a difference
    # between the above, and
    fields = _m.concrete_fields + _m.many_to_many + _m.virtual_fields
    # ... and to also see what's the minimum django version with this previous api

As for the implementation, I'd cache the immutable fields and let everything else fall through. If they're stored in a {name: field} dictionary that would also allow for more field-specific checks instead of this big if.

The new question will be then if one wants to allow the dubious feature of specifying non-field attributes in immutable_fields. :)

[timdiggins]

@xlotlu true it's "my" project -- but I don't use Django much any more (and I don't really use the project) so if you want to do pull-requests, I don't mind the project in your direction, and you can take it over if you're keen!

[xlotlu]

@timdiggins thanks, message received. If I intend to code some large-ish makeover I'll consider the responsibility and will let you know, until then I guess I'll patch this thing here.