Allow args in post_list template. Build

Author: joelworsham

README.md

@@ -63,7 +63,7 @@ Simply download the master zip (the button on the right that says "Download ZIP"
 * UPDATE: Force require at least PHP 5.3.
 * DEVELOPERS: Improve shortcode attribute template functionality, especially the post list template.
 
-### [1.0.2](https://github.com/brashrebel/render/releases/tag/v1.0.2)
+### [1.1-beta-2](https://github.com/brashrebel/render/releases/tag/v1.0.2)
 * FIX: Content in shortcodes disappearing when adding one shortcode into the entire content of another.
 * FIX: Potential PHP notice of defining a licensing constant.
 * UPDATE: Improved TinyMCE shortcode tooltip usability.

build/core/functions.php

@@ -463,18 +463,16 @@ function render_sc_attr_template( $template, $extra = array(), $args = array() )
 
 		case 'link':
 
-			// FIXME Allow args to be passed through to render_sc_post_list which allows choosing what's used as the value and name in the options list
-
 			$output = array(
 				'label'       => __( 'Link', 'Render' ),
 				'description' => __( 'Links to a post / page.', 'Render' ),
 				'type'        => 'selectbox',
 				'properties'  => array(
 					'placeholder'      => __( 'Select a post / page, or type a link', 'Render' ),
 					'allowCustomInput' => true,
-					'groups'           => array(),
 					'callback'         => array(
 						'function' => 'render_sc_post_list',
+						'args' => $args,
 					),
 				),
 			);

build/core/modal.php

@@ -535,8 +535,20 @@ private static function att_type_selectbox( $att_id, $att, $properties = array()
 
 		if ( ! empty( $options ) ) {
 
-			// We need to merge our arrays, but we need to do it with either groups or options (whichever is in use)
-			$which = ! empty( $properties['groups'] ) ? 'groups' : 'options';
+			// Figure out if groups or not
+			$which = 'options';
+			foreach ( $options as $option_value ) {
+				if ( is_array( $option_value ) ) {
+					$which = 'groups';
+					break;
+				}
+			}
+
+			// Icons are different
+			if ( $properties['allowIcons'] ) {
+				$which = 'options';
+			}
+
 			if ( ! empty( $properties[ $which ] ) ) {
 				$properties[ $which ] = array_merge( $options, $properties[ $which ] );
 			} else {

build/core/shortcodes/core/query.php

@@ -84,6 +84,7 @@
 					'label'       => __( 'Include', 'Render' ),
 					'properties'  => array(
 						'multi' => true,
+						'placeholder' => 'Select an option',
 					),
 					'conditional' => array(
 						'populate' => array(
@@ -98,6 +99,7 @@
 					'label'       => __( 'Exclude', 'Render' ),
 					'properties'  => array(
 						'multi' => true,
+						'placeholder' => 'Select an option',
 					),
 					'conditional' => array(
 						'populate' => array(

src/core/functions.php

@@ -463,19 +463,16 @@ function render_sc_attr_template( $template, $extra = array(), $args = array() )
 
 		case 'link':
 
-			// FIXME Allow args to be passed through to render_sc_post_list which allows choosing what's used as the value and name in the options list
-
 			$output = array(
 				'label'       => __( 'Link', 'Render' ),
 				'description' => __( 'Links to a post / page.', 'Render' ),
 				'type'        => 'selectbox',
 				'properties'  => array(
 					'placeholder'      => __( 'Select a post / page, or type a link', 'Render' ),
 					'allowCustomInput' => true,
-					'groups'           => array(),
 					'callback'         => array(
-						'groups'   => true,
 						'function' => 'render_sc_post_list',
+						'args' => $args,
 					),
 				),
 			);